linux-kernel - [PATCH 3/4] soc: mediatek: mtk-devapc: refine DEVAPC clock control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251212031450.489128-4-xiaoshun.xu@mediatek.corp-partner.google.com>
Date: Fri, 12 Dec 2025 11:13:44 +0800
From: Xiaoshun Xu <xiaoshun.xu@...iatek.corp-partner.google.com>
To: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Matthias Brugger
	<matthias.bgg@...il.com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, Xiaoshun Xu
	<xiaoshun.xu@...iatek.com>
CC: <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-mediatek@...ts.infradead.org>,
	Sirius Wang <sirius.wang@...iatek.com>, Vince-wl Liu
	<vince-wl.liu@...iatek.com>,
	<Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: [PATCH 3/4] soc: mediatek: mtk-devapc: refine DEVAPC clock control


External email : Please do not click links or open attachments until you have verified the sender or the content.


From: "xiaoshun.xu" <xiaoshun.xu@...iatek.com>

Because the new DEVAPC design, DEVAPC clock is controlled by
HW power domains, the control flow of DEVAPC clock is not
necessary, but to maintain compatibility with legacy ICs,
keep this part of code.

Signed-off-by: xiaoshun.xu <xiaoshun.xu@...iatek.com>
---
 drivers/soc/mediatek/mtk-devapc.c | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/drivers/soc/mediatek/mtk-devapc.c b/drivers/soc/mediatek/mtk-devapc.c
index 6dbec4016a24..18964d82ff08 100644
--- a/drivers/soc/mediatek/mtk-devapc.c
+++ b/drivers/soc/mediatek/mtk-devapc.c
@@ -359,16 +359,25 @@ static int mtk_devapc_probe(struct platform_device *pdev)
                goto err;
        }

-       ctx->infra_clk = devm_clk_get_enabled(&pdev->dev, "devapc-infra-clock");
+       /*
+        * The new design of DAPC clock is controlled by HW power domains,
+        * making it unnecessary to provide the clock control driver.
+        */
+       ctx->infra_clk = devm_clk_get_optional(&pdev->dev, "devapc-infra-clock");
        if (IS_ERR(ctx->infra_clk)) {
-               ret = -EINVAL;
-               goto err;
+               dev_dbg(ctx->dev, "Cannot get devapc clock from CCF\n");
+               ctx->infra_clk = NULL;
+       } else {
+               if (clk_prepare_enable(ctx->infra_clk))
+                       return -EINVAL;
        }

        ret = devm_request_irq(&pdev->dev, devapc_irq, devapc_violation_irq,
-                              IRQF_TRIGGER_NONE, "devapc", ctx);
-       if (ret)
+                              IRQF_TRIGGER_NONE | IRQF_SHARED, "devapc", ctx);
+       if (ret) {
+               clk_disable_unprepare(ctx->infra_clk);
                goto err;
+       }

        platform_set_drvdata(pdev, ctx);

@@ -387,6 +396,8 @@ static void mtk_devapc_remove(struct platform_device *pdev)

        stop_devapc(ctx);

+       clk_disable_unprepare(ctx->infra_clk);
+
        iounmap(ctx->base);
 }

--
2.45.2