linux-kernel - Re: [PATCH] KVM: arm64: vgic: simplify vgic_v3_redist_region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86pl8kniud.wl-maz@kernel.org>
Date: Fri, 12 Dec 2025 09:35:22 +0000
From: Marc Zyngier <maz@...nel.org>
To: Osama Abdelkader <osama.abdelkader@...il.com>
Cc: Oliver Upton <oupton@...nel.org>,
	Joey Gouly <joey.gouly@....com>,
	Suzuki K Poulose <suzuki.poulose@....com>,
	Zenghui Yu <yuzenghui@...wei.com>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>,
	Timothy Hayes <timothy.hayes@....com>,
	Sascha Bischoff <Sascha.Bischoff@....com>,
	Raghavendra Rao Ananta <rananta@...gle.com>,
	Jing Zhang <jingzhangos@...gle.com>,
	linux-arm-kernel@...ts.infradead.org,
	kvmarm@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: arm64: vgic: simplify vgic_v3_redist_region_full()

On Thu, 11 Dec 2025 22:51:09 +0000,
Osama Abdelkader <osama.abdelkader@...il.com> wrote:
> 
> Simplify the function by converting the if-return-false pattern to a
> direct boolean expression return, making the code more concise and
> readable.
> 
> Signed-off-by: Osama Abdelkader <osama.abdelkader@...il.com>
> ---
>  arch/arm64/kvm/vgic/vgic.h | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/kvm/vgic/vgic.h b/arch/arm64/kvm/vgic/vgic.h
> index 5f0fc96b4dc2..04dd2055e7df 100644
> --- a/arch/arm64/kvm/vgic/vgic.h
> +++ b/arch/arm64/kvm/vgic/vgic.h
> @@ -382,10 +382,7 @@ static inline int vgic_v3_max_apr_idx(struct kvm_vcpu *vcpu)
>  static inline bool
>  vgic_v3_redist_region_full(struct vgic_redist_region *region)
>  {
> -	if (!region->count)
> -		return false;
> -
> -	return (region->free_index >= region->count);
> +	return region->count > 0 && region->free_index >= region->count;
>  }
>  
>  struct vgic_redist_region *vgic_v3_rdist_free_slot(struct list_head *rdregs);

This is not clearer. Checking for 0 is pretty important as it outlines
a specific condition, which is why this is written as a separate
statement.

Please stop sending patches that are only aligning things to your
personal taste. There is no shortage of real problems to fix in the
kernel, your time is better spent on that, and mine on reviewing
useful patches.

	M.

-- 
Without deviation from the norm, progress is not possible.