linux-kernel - Re: [PATCH 04/14] greybus: cpc: pack cport ID in Greybus header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DEWECPRPKJEH.2P0LA0SMUPDU5@silabs.com>
Date: Fri, 12 Dec 2025 11:59:38 -0500
From: "Yacin Belmihoub-Martel" <yacin.belmihoub-martel@...abs.com>
To: Damien Riégel <damien.riegel@...abs.com>,
        <greybus-dev@...ts.linaro.org>
Cc: <linux-kernel@...r.kernel.org>, "Johan Hovold" <johan@...nel.org>,
        "Alex
 Elder" <elder@...nel.org>,
        "Greg Kroah-Hartman"
 <gregkh@...uxfoundation.org>,
        "Silicon Labs Kernel Team"
 <linux-devel@...abs.com>
Subject: Re: [PATCH 04/14] greybus: cpc: pack cport ID in Greybus header

On Fri Dec 12, 2025 at 11:12 AM EST, Damien Riégel wrote:
> +/**
> + * cpc_cport_unpack() - Unpack CPort ID from Greybus Operation Message header.
> + * @gb_hdr: Greybus operation message header.
> + *
> + * Return: CPort ID packed in the header.
> + */
> +u16 cpc_cport_unpack(struct gb_operation_msg_hdr *gb_hdr)
> +{
> +	return get_unaligned_le16(gb_hdr->pad);
> +}

We probably want to clear the packing from the `gb_hdr`, just like it is
done in the es2 driver.

Thanks,
-- 
Yacin Belmihoub-Martel
Silicon Laboratories