linux-kernel - Re: [PATCH v4 1/1] i40e: validate ring_len parameter against hardware-specific values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTx4_kJ8oex50QKP@oracle>
Date: Fri, 12 Dec 2025 21:20:14 +0100
From: Gregory Herrero <gregory.herrero@...cle.com>
To: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
Cc: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>,
        "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/1] i40e: validate ring_len parameter against
 hardware-specific values

On Mon, Nov 17, 2025 at 11:58:48AM +0000, Loktionov, Aleksandr wrote:
> 
> 
> > -----Original Message-----
> > From: gregory.herrero@...cle.com <gregory.herrero@...cle.com>
> > Sent: Monday, November 17, 2025 9:33 AM
> > To: Loktionov, Aleksandr <aleksandr.loktionov@...el.com>; Nguyen,
> > Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> > <przemyslaw.kitszel@...el.com>; andrew+netdev@...n.ch;
> > davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> > pabeni@...hat.com
> > Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-
> > kernel@...r.kernel.org; Gregory Herrero <gregory.herrero@...cle.com>
> > Subject: [PATCH v4 1/1] i40e: validate ring_len parameter against
> > hardware-specific values
> > 
> > From: Gregory Herrero <gregory.herrero@...cle.com>
> > 
> > The maximum number of descriptors supported by the hardware is
> > hardware dependent and can be retrieved using
> First paragraph uses “hardware dependent” (no hyphen) while later text uses “hardware‑specific” (hyphenated).
> Prefer “hardware‑dependent” for consistency.
> 
I will address in v5
> > i40e_get_max_num_descriptors().
> > Move this function to a shared header and use it when checking for
> > valid ring_len parameter rather than using hardcoded value.
> > 
> > By fixing an over-acceptance issue, behavior change could be seen
> > where ring_len could now be rejected while configuring rx and tx
> > queues if its size is larger than the hardware-specific maximum number
> > of descriptors.
> > 
> The message explains the behavioral change but does not state how the change was tested
> (e.g., which MAC types exercised, ethtool -G paths, VF configuration via virtchnl, acceptance/rejection boundaries). 
> Netdev routinely asks for this when behavior changes.
> 
In the meantime, Rafal Romanowski tested it so I will add:
Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>

Let me know if that's enough or if more details are required.

Thanks,
Gregory