linux-kernel - Re: [PATCH v21 3/7] firmware: imx: add driver for NXP EdgeLock Enclave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202512130804.vObtjguS-lkp@intel.com>
Date: Sat, 13 Dec 2025 08:45:34 +0800
From: kernel test robot <lkp@...el.com>
To: Pankaj Gupta <pankaj.gupta@....com>, Jonathan Corbet <corbet@....net>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, Frank Li <Frank.Li@....com>
Subject: Re: [PATCH v21 3/7] firmware: imx: add driver for NXP EdgeLock
 Enclave

Hi Pankaj,

kernel test robot noticed the following build errors:

[auto build test ERROR on 4a26e7032d7d57c998598c08a034872d6f0d3945]

url:    https://github.com/intel-lab-lkp/linux/commits/Pankaj-Gupta/Documentation-firmware-add-imx-se-to-other_interfaces/20251212-172535
base:   4a26e7032d7d57c998598c08a034872d6f0d3945
patch link:    https://lore.kernel.org/r/20251212-imx-se-if-v21-3-ee7d6052d848%40nxp.com
patch subject: [PATCH v21 3/7] firmware: imx: add driver for NXP EdgeLock Enclave
config: sparc64-allmodconfig (https://download.01.org/0day-ci/archive/20251213/202512130804.vObtjguS-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 1335a05ab8bc8339ce24be3a9da89d8c3f4e0571)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251213/202512130804.vObtjguS-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512130804.vObtjguS-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/firmware/imx/se_ctrl.c:168:6: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     168 |         if (FIELD_GET(DEV_GETINFO_MIN_VER_MASK, var_se_info.soc_rev))
         |             ^
   1 error generated.
--
>> drivers/firmware/imx/ele_common.c:241:11: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     241 |         status = RES_STATUS(msg->data[0]);
         |                  ^
   drivers/firmware/imx/se_ctrl.h:16:25: note: expanded from macro 'RES_STATUS'
      16 | #define RES_STATUS(x)                   FIELD_GET(0x000000ff, x)
         |                                         ^
   1 error generated.


vim +/FIELD_GET +168 drivers/firmware/imx/se_ctrl.c

   137	
   138	static int get_se_soc_info(struct se_if_priv *priv, const struct se_soc_info *se_info)
   139	{
   140		struct se_fw_load_info *load_fw = get_load_fw_instance(priv);
   141		struct soc_device_attribute *attr;
   142		u8 data[MAX_SOC_INFO_DATA_SZ];
   143		struct ele_dev_info *s_info;
   144		struct soc_device *sdev;
   145		int err = 0;
   146	
   147		/*
   148		 * This function should be called once.
   149		 * Check if the se_soc_rev is zero to continue.
   150		 */
   151		if (var_se_info.soc_rev)
   152			return err;
   153	
   154		err = ele_fetch_soc_info(priv, &data);
   155		if (err < 0)
   156			return dev_err_probe(priv->dev, err, "Failed to fetch SoC Info.");
   157		s_info = (void *)data;
   158		var_se_info.soc_rev = s_info->d_info.soc_rev;
   159		load_fw->imem.state = s_info->d_addn_info.imem_state;
   160	
   161		if (!se_info->soc_register)
   162			return 0;
   163	
   164		attr = devm_kzalloc(priv->dev, sizeof(*attr), GFP_KERNEL);
   165		if (!attr)
   166			return -ENOMEM;
   167	
 > 168		if (FIELD_GET(DEV_GETINFO_MIN_VER_MASK, var_se_info.soc_rev))
   169			attr->revision = devm_kasprintf(priv->dev, GFP_KERNEL, "%x.%x",
   170							FIELD_GET(DEV_GETINFO_MIN_VER_MASK,
   171								  var_se_info.soc_rev),
   172							FIELD_GET(DEV_GETINFO_MAJ_VER_MASK,
   173								  var_se_info.soc_rev));
   174		else
   175			attr->revision = devm_kasprintf(priv->dev, GFP_KERNEL, "%x",
   176							FIELD_GET(DEV_GETINFO_MAJ_VER_MASK,
   177								  var_se_info.soc_rev));
   178	
   179		switch (se_info->soc_id) {
   180		case SOC_ID_OF_IMX8ULP:
   181			attr->soc_id = "i.MX8ULP";
   182			break;
   183		case SOC_ID_OF_IMX93:
   184			attr->soc_id = "i.MX93";
   185			break;
   186		}
   187	
   188		err = of_property_read_string(of_root, "model", &attr->machine);
   189		if (err)
   190			return -EINVAL;
   191	
   192		attr->family = "Freescale i.MX";
   193	
   194		attr->serial_number = devm_kasprintf(priv->dev,
   195						     GFP_KERNEL, "%016llX",
   196						     GET_SERIAL_NUM_FROM_UID(s_info->d_info.uid,
   197									     MAX_UID_SIZE >> 2));
   198	
   199		sdev = soc_device_register(attr);
   200		if (IS_ERR(sdev))
   201			return PTR_ERR(sdev);
   202	
   203		return 0;
   204	}
   205	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki