linux-kernel - Re: [PATCH RFC] soc: qcom: socinfo: Re-implement in Rust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025121303-railing-fountain-bebf@gregkh>
Date: Sat, 13 Dec 2025 14:57:22 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Matthew Maurer <mmaurer@...gle.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Satya Durga Srinivasu Prabhala <satyap@...cinc.com>,
	Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>,
	Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <lossin@...nel.org>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	Danilo Krummrich <dakr@...nel.org>, Trilok Soni <tsoni@...cinc.com>,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	rust-for-linux@...r.kernel.org
Subject: Re: [PATCH RFC] soc: qcom: socinfo: Re-implement in Rust

On Sat, Dec 13, 2025 at 12:36:00AM +0000, Matthew Maurer wrote:
>  drivers/soc/qcom/Kconfig             |   1 +
>  drivers/soc/qcom/Makefile            |   2 +-
>  drivers/soc/qcom/socinfo.c           | 931 -----------------------------------
>  drivers/soc/qcom/socinfo/Makefile    |   2 +
>  drivers/soc/qcom/socinfo/bindings.rs |  59 +++
>  drivers/soc/qcom/socinfo/data.rs     | 424 ++++++++++++++++
>  drivers/soc/qcom/socinfo/socinfo.rs  | 362 ++++++++++++++

Shouldn't this all just be in 1 .rs file?  By not doing that, you have a
number of public symbols (that are very generic), that will "pollute"
the global namespace of the kernel symbol table (unless rust does this
somehow differently?)

But putting this all in 1 file should solve all of that, and remove all
global symbols.  Especially for just a small and simple driver like
this, no need to split it up at all.

thanks,

greg k-h