linux-kernel - Re: [PATCH v3] staging: fluke_gpib: use kzalloc instead of kmalloc + memset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aT16t-dFDMg7cR2M@egonzo>
Date: Sat, 13 Dec 2025 15:39:51 +0100
From: Dave Penkler <dpenkler@...il.com>
To: Tomasz Sadowski <tsdwski@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] staging: fluke_gpib: use kzalloc instead of kmalloc +
 memset

On Thu, Nov 27, 2025 at 10:58:49AM +0100, Tomasz Sadowski wrote:
> Use kzalloc() instead of kmalloc() + memset() to simplify memory allocation.
> 
> Also use sizeof(*board->private_data) instead of repeating the struct name.
> This avoids duplication and keeps the code correct if the struct name
> changes in the future.
> 
> Signed-off-by: Tomasz Sadowski <tsdwski@...il.com>
> ---
> v3:
>  - Move version history below "---"
> 
> v2:
>  - Add proper commit description
>  - No changes in patch
> 
>  drivers/staging/gpib/eastwood/fluke_gpib.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/gpib/eastwood/fluke_gpib.c b/drivers/staging/gpib/eastwood/fluke_gpib.c
> index 3ae848e3f738..2b6ba7882dba 100644
> --- a/drivers/staging/gpib/eastwood/fluke_gpib.c
> +++ b/drivers/staging/gpib/eastwood/fluke_gpib.c
> @@ -853,11 +853,10 @@ static int fluke_allocate_private(struct gpib_board *board)
>  {
>  	struct fluke_priv *priv;
>  
> -	board->private_data = kmalloc(sizeof(struct fluke_priv), GFP_KERNEL);
> +	board->private_data = kzalloc(sizeof(*board->private_data), GFP_KERNEL);

Good thing to use kzalloc here but using sizeof(*board->private_data) will
not work. sizeof(void) is 1 not the size of the structure.

>  	if (!board->private_data)
>  		return -ENOMEM;
>  	priv = board->private_data;
> -	memset(priv, 0, sizeof(struct fluke_priv));
>  	init_nec7210_private(&priv->nec7210_priv);
>  	priv->dma_buffer_size = 0x7ff;
>  	priv->dma_buffer = kmalloc(priv->dma_buffer_size, GFP_KERNEL);
> -- 
> 2.52.0
>