linux-kernel - Re: [PATCH RFC] soc: qcom: socinfo: Re-implement in Rust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGSQo01p2h53h35y_1z6+D=EGnT2TvvcYSwgfgK-hAOULEkUag@mail.gmail.com>
Date: Sat, 13 Dec 2025 09:11:25 -0800
From: Matthew Maurer <mmaurer@...gle.com>
To: Greg KH <greg@...ah.com>
Cc: Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	Satya Durga Srinivasu Prabhala <satyap@...cinc.com>, Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, Trilok Soni <tsoni@...cinc.com>, linux-kernel@...r.kernel.org, 
	linux-arm-msm@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH RFC] soc: qcom: socinfo: Re-implement in Rust

On Sat, Dec 13, 2025 at 8:26 AM Matthew Maurer <mmaurer@...gle.com> wrote:
>
> On Sat, Dec 13, 2025 at 5:28 AM Greg KH <greg@...ah.com> wrote:
> >
> > On Sat, Dec 13, 2025 at 12:36:00AM +0000, Matthew Maurer wrote:
> > > Re-implements qcom-socinfo driver in Rust, using `Scoped`-based DebugFS
> > > bindings.
> > >
> > > Signed-off-by: Matthew Maurer <mmaurer@...gle.com>
> > > ---
> > > This patch converts the QC socinfo driver to Rust, intended to be the
> > > first Rust driver in Android that is owned by a vendor rather than the
> > > platform.
> >
> > Um, shouldn't you have a signed-off-by from the maintainers of the .c
> > file here?  You are deleting it, and then not adding anything to the
> > MAINTAINERS file to take ownership of this new file, which I thought
> > checkpatch would have warned about.
>
> Checkpatch did not warn me about this, but I did add the maintainers
> of that file on this RFC, so we can see how they feel about it on this
> thread.
>

Further clarification - checkpatch *did* warn me that perhaps
MAINTAINERS needed updating because files were added or removed, but I
saw that the maintainers were by `drivers/soc/qcom` which should
include all the new files. It did not warn me that I needed any
additional Signed-off-by lines.

> >
> > thanks,
> >
> > greg k-h