linux-kernel - Re: [PATCH v3 3/3] sched_ext: Allow scx_bpf_reenqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aTy-69iu1wiqmW4y@slm.duckdns.org>
Date: Fri, 12 Dec 2025 15:18:35 -1000
From: Tejun Heo <tj@...nel.org>
To: Andrea Righi <arighi@...dia.com>
Cc: Kuba Piecuch <jpiecuch@...gle.com>, David Vernet <void@...ifault.com>,
	Changwoo Min <changwoo@...lia.com>, linux-kernel@...r.kernel.org,
	sched-ext@...ts.linux.dev, Peter Zijlstra <peterz@...radead.org>,
	Wen-Fang Liu <liuwenfang@...or.com>
Subject: Re: [PATCH v3 3/3] sched_ext: Allow scx_bpf_reenqueue_local() to be
 called from anywhere

On Sat, Dec 13, 2025 at 02:16:44AM +0100, Andrea Righi wrote:
> > That doesn't fix the ordering problem in the other direction, but the
> > reordering in the other direction seems inherently less useful at least.
> > Maybe this can also be solved with seq - ie. make enqueue record the current
> > seq, mark the DSQ with the latest reenqueue seq and at enqueue commit time
> > if the captured seq is alreaddy reenqueued, trigger reenqueue.
> 
> How about making it even more explicit renaming the kfunc to something like
> scx_bpf_async_reenqueue_local() (and documenting it)?

I don't know. It's an implementation detail that can change in the future
and we don't want to be adding _async to e.g. scx_bpf_dsq_insert() too.

Thanks.

-- 
tejun