linux-kernel - Re: [RFC PATCH v2 5/6] fuse: factor out NFS export related code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOQ4uxgXdOpr_qYH9hg-nKMLFj06XJP4c1yZ8ZJzCvdCtUok9A@mail.gmail.com>
Date: Sun, 14 Dec 2025 16:13:43 +0100
From: Amir Goldstein <amir73il@...il.com>
To: Luis Henriques <luis@...lia.com>
Cc: Miklos Szeredi <miklos@...redi.hu>, "Darrick J. Wong" <djwong@...nel.org>, 
	Bernd Schubert <bschubert@....com>, Kevin Chen <kchen@....com>, 
	Horst Birthelmer <hbirthelmer@....com>, linux-fsdevel@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Matt Harvey <mharvey@...ptrading.com>, 
	kernel-dev@...lia.com
Subject: Re: [RFC PATCH v2 5/6] fuse: factor out NFS export related code

On Fri, Dec 12, 2025 at 7:13 PM Luis Henriques <luis@...lia.com> wrote:
>
> Move all the NFS-related code into a different file.  This is just
> preparatory work to be able to use the LOOKUP_HANDLE file handles as the NFS
> handles.
>
> Signed-off-by: Luis Henriques <luis@...lia.com>

Very nice.
Apart from minor nit below, feel free to add:

Reviewed-by: Amir Goldstein <amir73il@...il.com>

> ---
>  fs/fuse/Makefile |   2 +-
>  fs/fuse/dir.c    |   1 +
>  fs/fuse/export.c | 174 +++++++++++++++++++++++++++++++++++++++++++++++
>  fs/fuse/fuse_i.h |   6 ++
>  fs/fuse/inode.c  | 167 +--------------------------------------------
>  5 files changed, 183 insertions(+), 167 deletions(-)
>  create mode 100644 fs/fuse/export.c
>
> diff --git a/fs/fuse/Makefile b/fs/fuse/Makefile
> index 22ad9538dfc4..1d1401658278 100644
> --- a/fs/fuse/Makefile
> +++ b/fs/fuse/Makefile
> @@ -12,7 +12,7 @@ obj-$(CONFIG_VIRTIO_FS) += virtiofs.o
>
>  fuse-y := trace.o      # put trace.o first so we see ftrace errors sooner
>  fuse-y += dev.o dir.o file.o inode.o control.o xattr.o acl.o readdir.o ioctl.o
> -fuse-y += iomode.o
> +fuse-y += iomode.o export.o
>  fuse-$(CONFIG_FUSE_DAX) += dax.o
>  fuse-$(CONFIG_FUSE_PASSTHROUGH) += passthrough.o backing.o
>  fuse-$(CONFIG_SYSCTL) += sysctl.o
> diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
> index a6edb444180f..a885f1dc61eb 100644
> --- a/fs/fuse/dir.c
> +++ b/fs/fuse/dir.c
> @@ -190,6 +190,7 @@ static void fuse_lookup_init(struct fuse_conn *fc, struct fuse_args *args,
>
>                 args->opcode = FUSE_LOOKUP_HANDLE;
>                 args->out_argvar = true;
> +               args->out_argvar_idx = 0;
>

This change looks out of place.

Keep in mind that it may take me some time to get to the rest of the patches,
but this one was a low hanging review.

Thanks,
Amir.