[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20251214152021.72081e78@jic23-huawei>
Date: Sun, 14 Dec 2025 15:20:21 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Petre Rodan <petre.rodan@...dimension.ro>, David Lechner
<dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, Andy
Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof
Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: iio: pressure: add
honeywell,abp2030pa
On Mon, 8 Dec 2025 08:21:49 +0100
Krzysztof Kozlowski <krzk@...nel.org> wrote:
> On 08/12/2025 08:15, Petre Rodan wrote:
> >
> > hello Krzysztof,
> >
> > On Mon, Dec 08, 2025 at 06:01:46AM +0100, Krzysztof Kozlowski wrote:
> >> On 07/12/2025 07:00, Petre Rodan wrote:
> >>> Adds binding for digital Honeywell ABP2 series pressure and temperature
> >>> sensors.
> >>> The i2c address is hardcoded and depends on the part number.
> >>> There is an optional interrupt that signals the end of conversion.
> >>>
> >>> Signed-off-by: Petre Rodan <petre.rodan@...dimension.ro>
> >>
> >> <form letter>
> >> This is a friendly reminder during the review process.
> >>
> >> It looks like you received a tag and forgot to add it.
> >
> > [..]
> >
> >> If a tag was not added on purpose, please state why and what changed.
> >> </form letter>
> >
> > I removed the tag on purpose since the yaml file was modified in v4 as per the
> > changelog that is below the commit message.
>
> Please read my form letter and please read linked submitting patches
> doc. I pointed to a very specific paragraph, so you don't need to read
> everything...
>
> >
> >> I will not be doing work twice and, without explanation, forcing me to
> >> do that is disrespectful to my time.
> >
> > sorry about that. the single thing that changed was that
> >
> > ---- 8< --------------------------------------------
> > @@ -76,8 +71,7 @@ properties:
> > spi-max-frequency:
> > maximum: 800000
> >
> > - vdd-supply:
> > - description: provide VDD power to the sensor.
> > + vdd-supply: true
> >
>
>
> This is trivial and absolutely NOT a reason to drop the tag. Did you
> read submitting patches document? Please consider TIME of reviewers,
> even time spent on replying on this.
I put the tag back and applied to the testing branch of iio.git.
I'll rebase that on rc1 once it is available.
Thanks,
Jonathan
Powered by blists - more mailing lists