| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202512142226.in31LpSK-lkp@intel.com>
Date: Sun, 14 Dec 2025 22:34:46 +0100
From: kernel test robot <lkp@...el.com>
To: Peter Zijlstra <peterz@...radead.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
x86@...nel.org, Ingo Molnar <mingo@...nel.org>
Subject: [tip:sched/core 9/16] kernel/sched/ext.c:2434:9: error: implicit
declaration of function 'rq_modified_clear'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched/core
head: 098f3900b035ab94fccd19d77b9ec2b13c300599
commit: 31ab17f00c810076333c26cb485ec4d778829a76 [9/16] sched/core: Rework sched_class::wakeup_preempt() and rq_modified_*()
config: x86_64-rhel-9.4-bpf (https://download.01.org/0day-ci/archive/20251214/202512142226.in31LpSK-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251214/202512142226.in31LpSK-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512142226.in31LpSK-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from kernel/sched/build_policy.c:62:
kernel/sched/ext.c: In function 'do_pick_task_scx':
>> kernel/sched/ext.c:2434:9: error: implicit declaration of function 'rq_modified_clear' [-Wimplicit-function-declaration]
2434 | rq_modified_clear(rq);
| ^~~~~~~~~~~~~~~~~
>> kernel/sched/ext.c:2449:27: error: implicit declaration of function 'rq_modified_above' [-Wimplicit-function-declaration]
2449 | if (!force_scx && rq_modified_above(rq, &ext_sched_class))
| ^~~~~~~~~~~~~~~~~
kernel/sched/ext.c: In function 'scx_vexit':
kernel/sched/ext.c:4683:9: warning: function 'scx_vexit' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
4683 | vscnprintf(ei->msg, SCX_EXIT_MSG_LEN, fmt, args);
| ^~~~~~~~~~
kernel/sched/ext.c: In function '__bstr_format':
kernel/sched/ext.c:6655:27: warning: function '__bstr_format' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
6655 | bprintf_data.bin_args);
| ^~~~~~~~~~~~
vim +/rq_modified_clear +2434 kernel/sched/ext.c
f0e1a0643a59bf Tejun Heo 2024-06-18 2423
67fa319f5fff52 Andrea Righi 2025-10-18 2424 static struct task_struct *
67fa319f5fff52 Andrea Righi 2025-10-18 2425 do_pick_task_scx(struct rq *rq, struct rq_flags *rf, bool force_scx)
f0e1a0643a59bf Tejun Heo 2024-06-18 2426 {
753e2836d139b4 Tejun Heo 2024-09-03 2427 struct task_struct *prev = rq->curr;
4c95380701f58b Peter Zijlstra 2025-10-01 2428 bool keep_prev, kick_idle = false;
f0e1a0643a59bf Tejun Heo 2024-06-18 2429 struct task_struct *p;
f0e1a0643a59bf Tejun Heo 2024-06-18 2430
a379fa1e2cae15 Tejun Heo 2025-10-22 2431 /* see kick_cpus_irq_workfn() */
987e00035c0e68 Tejun Heo 2025-10-22 2432 smp_store_release(&rq->scx.kick_sync, rq->scx.kick_sync + 1);
a379fa1e2cae15 Tejun Heo 2025-10-22 2433
4c95380701f58b Peter Zijlstra 2025-10-01 @2434 rq_modified_clear(rq);
70d837c3e017a0 Tejun Heo 2025-10-16 2435
4c95380701f58b Peter Zijlstra 2025-10-01 2436 rq_unpin_lock(rq, rf);
4c95380701f58b Peter Zijlstra 2025-10-01 2437 balance_one(rq, prev);
4c95380701f58b Peter Zijlstra 2025-10-01 2438 rq_repin_lock(rq, rf);
977b9a00541929 Peter Zijlstra 2025-10-28 2439 maybe_queue_balance_callback(rq);
70d837c3e017a0 Tejun Heo 2025-10-16 2440
67fa319f5fff52 Andrea Righi 2025-10-18 2441 /*
67fa319f5fff52 Andrea Righi 2025-10-18 2442 * If any higher-priority sched class enqueued a runnable task on
67fa319f5fff52 Andrea Righi 2025-10-18 2443 * this rq during balance_one(), abort and return RETRY_TASK, so
67fa319f5fff52 Andrea Righi 2025-10-18 2444 * that the scheduler loop can restart.
67fa319f5fff52 Andrea Righi 2025-10-18 2445 *
67fa319f5fff52 Andrea Righi 2025-10-18 2446 * If @force_scx is true, always try to pick a SCHED_EXT task,
67fa319f5fff52 Andrea Righi 2025-10-18 2447 * regardless of any higher-priority sched classes activity.
67fa319f5fff52 Andrea Righi 2025-10-18 2448 */
67fa319f5fff52 Andrea Righi 2025-10-18 @2449 if (!force_scx && rq_modified_above(rq, &ext_sched_class))
4c95380701f58b Peter Zijlstra 2025-10-01 2450 return RETRY_TASK;
4c95380701f58b Peter Zijlstra 2025-10-01 2451
4c95380701f58b Peter Zijlstra 2025-10-01 2452 keep_prev = rq->scx.flags & SCX_RQ_BAL_KEEP;
4c95380701f58b Peter Zijlstra 2025-10-01 2453 if (unlikely(keep_prev &&
8fef0a3b17bb25 Tejun Heo 2025-02-25 2454 prev->sched_class != &ext_sched_class)) {
1a7ff7216c8b4d Tejun Heo 2025-04-04 2455 WARN_ON_ONCE(scx_enable_state() == SCX_ENABLED);
a6250aa251eaca Tejun Heo 2024-11-09 2456 keep_prev = false;
a6250aa251eaca Tejun Heo 2024-11-09 2457 }
a6250aa251eaca Tejun Heo 2024-11-09 2458
a6250aa251eaca Tejun Heo 2024-11-09 2459 /*
a6250aa251eaca Tejun Heo 2024-11-09 2460 * If balance_scx() is telling us to keep running @prev, replenish slice
a6250aa251eaca Tejun Heo 2024-11-09 2461 * if necessary and keep running @prev. Otherwise, pop the first one
a6250aa251eaca Tejun Heo 2024-11-09 2462 * from the local DSQ.
a6250aa251eaca Tejun Heo 2024-11-09 2463 */
a6250aa251eaca Tejun Heo 2024-11-09 2464 if (keep_prev) {
7c65ae81ea86a6 Tejun Heo 2024-09-03 2465 p = prev;
69120f82282977 Honglei Wang 2025-04-18 2466 if (!p->scx.slice)
c0008a5632103e Tejun Heo 2025-09-23 2467 refill_task_slice_dfl(rcu_dereference_sched(scx_root), p);
7c65ae81ea86a6 Tejun Heo 2024-09-03 2468 } else {
f0e1a0643a59bf Tejun Heo 2024-06-18 2469 p = first_local_task(rq);
a6250aa251eaca Tejun Heo 2024-11-09 2470 if (!p) {
a6250aa251eaca Tejun Heo 2024-11-09 2471 if (kick_idle)
9fc687edf205db Tejun Heo 2025-09-23 2472 scx_kick_cpu(rcu_dereference_sched(scx_root),
9fc687edf205db Tejun Heo 2025-09-23 2473 cpu_of(rq), SCX_KICK_IDLE);
f0e1a0643a59bf Tejun Heo 2024-06-18 2474 return NULL;
a6250aa251eaca Tejun Heo 2024-11-09 2475 }
f0e1a0643a59bf Tejun Heo 2024-06-18 2476
f0e1a0643a59bf Tejun Heo 2024-06-18 2477 if (unlikely(!p->scx.slice)) {
c0008a5632103e Tejun Heo 2025-09-23 2478 struct scx_sched *sch = rcu_dereference_sched(scx_root);
d310fb40096896 Tejun Heo 2025-05-14 2479
d310fb40096896 Tejun Heo 2025-05-14 2480 if (!scx_rq_bypassing(rq) && !sch->warned_zero_slice) {
c425180d888e7d Honglei Wang 2024-10-10 2481 printk_deferred(KERN_WARNING "sched_ext: %s[%d] has zero slice in %s()\n",
c425180d888e7d Honglei Wang 2024-10-10 2482 p->comm, p->pid, __func__);
d310fb40096896 Tejun Heo 2025-05-14 2483 sch->warned_zero_slice = true;
f0e1a0643a59bf Tejun Heo 2024-06-18 2484 }
c0008a5632103e Tejun Heo 2025-09-23 2485 refill_task_slice_dfl(sch, p);
f0e1a0643a59bf Tejun Heo 2024-06-18 2486 }
7c65ae81ea86a6 Tejun Heo 2024-09-03 2487 }
7c65ae81ea86a6 Tejun Heo 2024-09-03 2488
f0e1a0643a59bf Tejun Heo 2024-06-18 2489 return p;
f0e1a0643a59bf Tejun Heo 2024-06-18 2490 }
f0e1a0643a59bf Tejun Heo 2024-06-18 2491
:::::: The code at line 2434 was first introduced by commit
:::::: 4c95380701f58b8112f0b891de8d160e4199e19d sched/ext: Fold balance_scx() into pick_task_scx()
:::::: TO: Peter Zijlstra <peterz@...radead.org>
:::::: CC: Peter Zijlstra <peterz@...radead.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists