linux-kernel - Re: [PATCH v8 2/2] iio: adc: Add ti-ads1018 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DEYCEJB4SWZ3.13MX1YUFLI1QI@gmail.com>
Date: Sun, 14 Dec 2025 18:53:19 -0500
From: "Kurt Borja" <kuurtb@...il.com>
To: "Jonathan Cameron" <jic23@...nel.org>, "Kurt Borja" <kuurtb@...il.com>
Cc: "Rob Herring" <robh@...nel.org>, "Krzysztof Kozlowski"
 <krzk+dt@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>, "Tobias
 Sperling" <tobias.sperling@...ting.com>, "David Lechner"
 <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>,
 "Andy Shevchenko" <andy@...nel.org>, <linux-iio@...r.kernel.org>,
 <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "Jonathan
 Cameron" <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH v8 2/2] iio: adc: Add ti-ads1018 driver

On Sun Dec 14, 2025 at 9:48 AM -05, Jonathan Cameron wrote:
> On Thu, 11 Dec 2025 23:25:44 -0500
> Kurt Borja <kuurtb@...il.com> wrote:
>
>> Add ti-ads1018 driver for Texas Instruments ADS1018 and ADS1118 SPI
>> analog-to-digital converters.
>> 
>> This chips' MOSI pin is shared with a data-ready interrupt. Defining
>> this interrupt in devicetree is optional, therefore we only create an
>> IIO trigger if one is found.
>> 
>> Handling this interrupt requires some considerations. When enabling the
>> trigger the CS line is tied low (active), thus we need to hold
>> spi_bus_lock() too, to avoid state corruption. This is done inside the
>> set_trigger_state() callback, to let users use other triggers without
>> wasting a bus lock.
>> 
>> Reviewed-by: Andy Shevchenko <andy@...nel.org>
>> Signed-off-by: Kurt Borja <kuurtb@...il.com>
>
> Hi Kurt, 
>
> A couple of minor formatting things. All trivial so I tweaked whilst
> applying. Applied to the testing branch of iio.git. I'll rebase that
> on rc1 once available then push out as togreg for linux-next to pick
> it up.
>
> Thanks,
>
> Jonathan

Hi Jonathan,

Thank you, Andy and David for your guidance (and the little tweaks) :)

-- 
 ~ Kurt