linux-kernel - Re: [PATCH v2] fbdev: arkfb: Request legacy VGA I/O region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251214111914.4976-1-swarajgaikwad1925@gmail.com>
Date: Sun, 14 Dec 2025 11:19:14 +0000
From: Swaraj Gaikwad <swarajgaikwad1925@...il.com>
To: sam@...nborg.org
Cc: Frank.Li@....com,
	akpm@...ux-foundation.org,
	david.hunter.linux@...il.com,
	deller@....de,
	donettom@...ux.ibm.com,
	dri-devel@...ts.freedesktop.org,
	hverkuil+cisco@...nel.org,
	kees@...nel.org,
	konrad.dybcio@....qualcomm.com,
	linux-fbdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	nicolas.dufresne@...labora.com,
	rongqianfeng@...o.com,
	skhan@...uxfoundation.org,
	swarajgaikwad1925@...il.com,
	vivek.kasireddy@...el.com,
	ydirson@...e.fr,
	ziy@...dia.com
Subject: Re: [PATCH v2] fbdev: arkfb: Request legacy VGA I/O region

Hi Sam,

Thanks for the review.

You are right that the cast to (void __iomem *) makes it look like memory,
but the resource is explicitly initialized as I/O ports a few lines earlier:

    vga_res.flags = IORESOURCE_IO;

Since the resource flag is IORESOURCE_IO (targeting the legacy VGA ports),
I used devm_request_region() instead of devm_request_mem_region().

Best regards,
Swaraj