linux-kernel - Re: [PATCH] xtensa: mmu: validate user access in fast_load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMo8BfLbKdjRTvqpnepM=tom+D-cGkHDw-GBo3d7Az_wV15o5w@mail.gmail.com>
Date: Sat, 13 Dec 2025 23:24:39 -0800
From: Max Filippov <jcmvbkbc@...il.com>
To: Ricky Ringler <richard.rringler@...il.com>
Cc: Chris Zankel <chris@...kel.net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xtensa: mmu: validate user access in fast_load_store with MMU

On Sat, Dec 13, 2025 at 11:14 PM Max Filippov <jcmvbkbc@...il.com> wrote:
> >  #ifdef CONFIG_MMU
> >         /* l32e can't be used here even when it's available. */
> > -       /* TODO access_ok(a3) could be used here */
> > -       j       .Linvalid_instruction
> > +       movi    a5, 8
> > +       access_ok a3, a5, a0, a2, .Linvalid_instruction
>
> New code should use tabs, not spaces, just like the existing code.

Disregard that, the other version of the patch is formatted with spaces,
this one is good.

Please add patch version if you send multiple versions of the patch.

-- 
Thanks.
-- Max