linux-kernel - Re: [PATCH v4 2/7] phy: Add driver for EyeQ5 Ethernet PHY wrapper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DEYXM6CGJULV.1KKA37ZLEIW1K@bootlin.com>
Date: Mon, 15 Dec 2025 17:30:41 +0100
From: Théo Lebrun <theo.lebrun@...tlin.com>
To: "Luca Ceresoli" <luca.ceresoli@...tlin.com>,
 Théo Lebrun <theo.lebrun@...tlin.com>, "Vladimir
 Kondratiev" <vladimir.kondratiev@...ileye.com>,
 Grégory Clement <gregory.clement@...tlin.com>, "Rob
 Herring" <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>,
 "Conor Dooley" <conor+dt@...nel.org>, "Vinod Koul" <vkoul@...nel.org>,
 "Kishon Vijay Abraham I" <kishon@...nel.org>, "Michael Turquette"
 <mturquette@...libre.com>, "Stephen Boyd" <sboyd@...nel.org>, "Philipp
 Zabel" <p.zabel@...gutronix.de>, "Thomas Bogendoerfer"
 <tsbogend@...ha.franken.de>
Cc: <linux-mips@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <linux-phy@...ts.infradead.org>,
 <linux-clk@...r.kernel.org>, Benoît Monin
 <benoit.monin@...tlin.com>, "Maxime Chevallier"
 <maxime.chevallier@...tlin.com>, "Tawfik Bayouk"
 <tawfik.bayouk@...ileye.com>, "Thomas Petazzoni"
 <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v4 2/7] phy: Add driver for EyeQ5 Ethernet PHY wrapper

On Mon Dec 15, 2025 at 4:11 PM CET, Luca Ceresoli wrote:
> On Mon Dec 15, 2025 at 4:08 PM CET, Théo Lebrun wrote:
>> On Wed Dec 10, 2025 at 5:06 PM CET, Luca Ceresoli wrote:
>>> On Mon Nov 24, 2025 at 3:41 PM CET, Théo Lebrun wrote:
>>>> +	provider = devm_of_phy_provider_register(dev, eq5_phy_xlate);
>>>> +	if (IS_ERR(provider)) {
>>>> +		dev_err(dev, "registering provider failed\n");
>>>> +		return PTR_ERR(provider);
>>>> +	}
>>>
>>> As above, why not dev_err_probe()?
>>
>> Good idea once again.
>>
>>> Other than the above minor issues, LGTM. This driver looks cleanly
>>> implemented.
>>
>> Thanks for the review. Does that imply I can append your Rb trailer?
>
> If you apply all the changes I have mention, yes, but in doubt you can
> avoid it and I'll review your next version. Re-reviewing is much faster
> than reviewing the first time (last famous words).

I've taken the Rb trailer, hoping everything is to your taste.

https://lore.kernel.org/lkml/20251215-macb-phy-v5-0-a9dfea39da34@bootlin.com/

Thanks,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com