linux-kernel - Re: [PATCH 04/46] rust: bitmap: add __rust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aUBApSU3gDPLBGSP@yury>
Date: Mon, 15 Dec 2025 12:08:53 -0500
From: Yury Norov <yury.norov@...il.com>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/46] rust: bitmap: add __rust_helper to helpers

On Tue, Dec 02, 2025 at 07:37:28PM +0000, Alice Ryhl wrote:
> This is needed to inline these helpers into Rust code.
> 
> Signed-off-by: Alice Ryhl <aliceryhl@...gle.com>
> ---
> Cc: Yury Norov <yury.norov@...il.com>
> ---
>  rust/helpers/bitmap.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/rust/helpers/bitmap.c b/rust/helpers/bitmap.c
> index a50e2f082e47ad1bacbf453fd79d1fdfe2cc11f5..57e9e64ab0c385cbaec8ba3f169bc304e07cf419 100644
> --- a/rust/helpers/bitmap.c
> +++ b/rust/helpers/bitmap.c
> @@ -2,8 +2,10 @@
>  
>  #include <linux/bitmap.h>
>  
> -void rust_helper_bitmap_copy_and_extend(unsigned long *to, const unsigned long *from,
> -		unsigned int count, unsigned int size)
> +__rust_helper void rust_helper_bitmap_copy_and_extend(unsigned long *to,
> +						      const unsigned long *from,
> +						      unsigned int count,
> +						      unsigned int size)
>  {
>  	bitmap_copy_and_extend(to, from, count, size);
>  }

Hi Alice,

Thanks for the series.

I've added patches 4, 5 and 12 in bitmap-for-next for testing.

Can you consider adding this prefix on a separate line, like this:

__rust_helper
void rust_helper_bitmap_copy_and_extend(unsigned long *to, const unsigned long *from,
             unsigned int count, unsigned int size)

This way you'd preserve more history, and make the patch intention
cleaner.

As said, I've added the patches in my branch, but if you're willing to
resend - I'll update those 3 patches in bitmap-for-next.

Thanks,
Yury