linux-kernel - Re: [PATCH] MIPS: Alchemy: Remove bogus static/inline specifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aUBCxRk1DfJdhtDh@alpha.franken.de>
Date: Mon, 15 Dec 2025 18:17:57 +0100
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: Thierry Reding <thierry.reding@...il.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: Alchemy: Remove bogus static/inline specifiers

On Wed, Oct 29, 2025 at 04:03:16PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@...dia.com>
> 
> The recent io_remap_pfn_range() rework applied the static and inline
> specifiers to the implementation of io_remap_pfn_range_pfn() on MIPS
> Alchemy, mirroring the same change on other platforms. However, this
> function is defined in a source file and that definition causes a
> conflict with its declaration. Fix this by dropping the specifiers.
> 
> Fixes: 8efb51ad1b05 ("mm: abstract io_remap_pfn_range() based on PFN")
> Signed-off-by: Thierry Reding <treding@...dia.com>
> ---
>  arch/mips/alchemy/common/setup.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/mips/alchemy/common/setup.c b/arch/mips/alchemy/common/setup.c
> index c35b4f809d51..992134a8c23a 100644
> --- a/arch/mips/alchemy/common/setup.c
> +++ b/arch/mips/alchemy/common/setup.c
> @@ -94,8 +94,7 @@ phys_addr_t fixup_bigphys_addr(phys_addr_t phys_addr, phys_addr_t size)
>  	return phys_addr;
>  }
>  
> -static inline unsigned long io_remap_pfn_range_pfn(unsigned long pfn,
> -		unsigned long size)
> +unsigned long io_remap_pfn_range_pfn(unsigned long pfn, unsigned long size)
>  {
>  	phys_addr_t phys_addr = fixup_bigphys_addr(pfn << PAGE_SHIFT, size);
>  
> -- 
> 2.51.0

applied to mips-fixes.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]