linux-kernel - Re: [PATCH v3] Input: rename INPUT_PROP_HAPTIC_TOUCHPAD to INPUT_PROP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <736q6nq1-0s4r-0q35-p2q0-p83n7o92p72p@xreary.bet>
Date: Mon, 15 Dec 2025 18:20:00 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: "Dmitry V. Levin" <ldv@...ace.io>
cc: Peter Hutterer <peter.hutterer@...-t.net>, 
    Jonathan Denose <jdenose@...gle.com>, 
    Benjamin Tissoires <bentiss@...nel.org>, 
    Dmitry Torokhov <dmitry.torokhov@...il.com>, 
    Jonathan Corbet <corbet@....net>, Henrik Rydberg <rydberg@...math.org>, 
    linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, 
    linux-doc@...r.kernel.org, Angela Czubak <aczubak@...gle.com>, 
    Sean O'Brien <seobrien@...gle.com>, Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH v3] Input: rename INPUT_PROP_HAPTIC_TOUCHPAD to
 INPUT_PROP_PRESSUREPAD

On Mon, 15 Dec 2025, Dmitry V. Levin wrote:

> > diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> > index 8ba48590bd2c..d21172c6a266 100644
> > --- a/include/uapi/linux/input-event-codes.h
> > +++ b/include/uapi/linux/input-event-codes.h
> > @@ -27,7 +27,7 @@
> >  #define INPUT_PROP_TOPBUTTONPAD		0x04	/* softbuttons at top of pad */
> >  #define INPUT_PROP_POINTING_STICK	0x05	/* is a pointing stick */
> >  #define INPUT_PROP_ACCELEROMETER	0x06	/* has accelerometer */
> > -#define INPUT_PROP_HAPTIC_TOUCHPAD	0x07	/* is a haptic touchpad */
> > +#define INPUT_PROP_PRESSUREPAD		0x07	/* pressure triggers clicks */
> >  
> >  #define INPUT_PROP_MAX			0x1f
> >  #define INPUT_PROP_CNT			(INPUT_PROP_MAX + 1)
> 
> When you rename UAPI constants, please don't forget to retain old names,
> otherwise there is a high chance you'll break userspace.
> This time you've broken the build of strace.

In general I'd agree, but in this particular case, both commits happened 
within the development window (6.18-rc1 vs 6.18-rc7).

"No breaking of userspace" is certainly a hard (and good) rule between 
actual existing version releases, but I hope we're not expected to adhere 
to it in between -rcs during a development cycle.

Thanks,

-- 
Jiri Kosina
SUSE Labs