linux-kernel - Re: [PATCH] of: replace strcmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251215192854.GA3162398-robh@kernel.org>
Date: Mon, 15 Dec 2025 13:28:54 -0600
From: Rob Herring <robh@...nel.org>
To: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: replace strcmp_suffix() with strends()

On Mon, Dec 15, 2025 at 04:48:09PM +0100, Bartosz Golaszewski wrote:
> string.h now provides strends() which fulfills the same role as the
> locally implemented strcmp_suffix(). Use it in of/property.c.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>
> ---
>  drivers/of/property.c | 15 ++-------------
>  1 file changed, 2 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/of/property.c b/drivers/of/property.c
> index 4e3524227720a..0a68223954f09 100644
> --- a/drivers/of/property.c
> +++ b/drivers/of/property.c
> @@ -1294,17 +1294,6 @@ static struct device_node *parse_##fname(struct device_node *np,	  \
>  	return parse_prop_cells(np, prop_name, index, name, cells);	  \
>  }
>  
> -static int strcmp_suffix(const char *str, const char *suffix)
> -{
> -	unsigned int len, suffix_len;
> -
> -	len = strlen(str);
> -	suffix_len = strlen(suffix);
> -	if (len <= suffix_len)
> -		return -1;
> -	return strcmp(str + len - suffix_len, suffix);
> -}
> -
>  /**
>   * parse_suffix_prop_cells - Suffix property parsing function for suppliers
>   *
> @@ -1331,7 +1320,7 @@ static struct device_node *parse_suffix_prop_cells(struct device_node *np,
>  {
>  	struct of_phandle_args sup_args;
>  
> -	if (strcmp_suffix(prop_name, suffix))
> +	if (strends(prop_name, suffix))
>  		return NULL;
>  
>  	if (of_parse_phandle_with_args(np, prop_name, cells_name, index,
> @@ -1416,7 +1405,7 @@ DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells")
>  static struct device_node *parse_gpios(struct device_node *np,
>  				       const char *prop_name, int index)
>  {
> -	if (!strcmp_suffix(prop_name, ",nr-gpios"))
> +	if (!strends(prop_name, ",nr-gpios"))

Don't you need to negate these?