linux-kernel - Re: [PATCH v3 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc15ff73-7322-41a9-b0db-a321d6835c36@kernel.org>
Date: Mon, 15 Dec 2025 21:33:30 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: David Heidelberg <david@...t.cz>,
 Lukas Timmermann <linux@...mermann.space>,
 Alim Akhtar <alim.akhtar@...sung.com>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Russell King <linux@...linux.org.uk>
Cc: linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 phone-devel@...r.kernel.org, Alexandre Marquet <tb@...arquet.fr>
Subject: Re: [PATCH v3 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10)

On 15/12/2025 21:06, David Heidelberg wrote:
>>>> +	aliases {
>>>> +		mmc0 = &mmc_0; /* eMMC */
>>>> +		mmc1 = &mmc_1; /* WiFi */
>>>> +	};
>>>> +
>>>> +	bmp180_vdda_reg: regulator-bmp180-vdda {
>>>> +		compatible = "regulator-fixed";
>>>> +		regulator-name = "BMP180_VDDA";
>>>> +	};
>>> something-something-regulator (all occurences within the DTS)
>>>
>>
>> I don't understand this suggestion.
> 
> oh right, let me clarify,
> 
> the regulator name should end with -regulator postfix.

That is not a correct suggestion for none of the SoC trees. If you
wanted to be consistent with old Exynos, then look at the sources - this
is voltage-regulator. But if we are nitpicking on that, this should be
either matching new code (regulator) or even the new style from DT bindings.

You have never reviewed anything on samsung-soc, so I wonder if this is
result of cc-ing this phone-devel. If that's the case, that list should
be just ignored.

Please do not nitpick on such stuff, especially on things not being
correct in terms of recommended style or bindings.

Best regards,
Krzysztof