linux-kernel - Re: [PATCH v5] dma-buf: add some tracepoints to debug.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251215153031.1a5e6d9f@gandalf.local.home>
Date: Mon, 15 Dec 2025 15:30:31 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Xiang Gao <gxxa03070307@...il.com>
Cc: sumit.semwal@...aro.org, christian.koenig@....com, mhiramat@...nel.org,
 linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, mathieu.desnoyers@...icios.com,
 dhowells@...hat.com, kuba@...nel.org, brauner@...nel.org,
 akpm@...ux-foundation.org, linux-trace-kernel@...r.kernel.org, gaoxiang17
 <gaoxiang17@...omi.com>
Subject: Re: [PATCH v5] dma-buf: add some tracepoints to debug.

On Mon,  1 Dec 2025 19:21:48 +0800
Xiang Gao <gxxa03070307@...il.com> wrote:

> --- a/drivers/dma-buf/dma-buf.c
> +++ b/drivers/dma-buf/dma-buf.c
> @@ -35,6 +35,17 @@
>  
>  #include "dma-buf-sysfs-stats.h"
>  
> +#define CREATE_TRACE_POINTS
> +#include <trace/events/dma_buf.h>
> +

From a tracing point of view I'm OK with this patch, but this macro really
needs a comment.

-- Steve

> +#define DMA_BUF_TRACE(FUNC, ...)                  \
> +    do {                                          \
> +        if (FUNC##_enabled()) {                   \
> +            guard(spinlock)(&dmabuf->name_lock); \
> +            FUNC(__VA_ARGS__);                    \
> +        }                                         \
> +    } while (0)
> +
>  static inline int is_dma_buf_file(struct file *);
>  
>  static DEFINE_MUTEX(dmabuf_list_mutex);