linux-kernel - Re: [PATCH 1/5] firmware: dmi: Correct an indexing error in dmi.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251215211143.GA355290@yaz-khff2.amd.com>
Date: Mon, 15 Dec 2025 16:11:43 -0500
From: Yazen Ghannam <yazen.ghannam@....com>
To: "Mario Limonciello (AMD)" <superm1@...nel.org>
Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
	Jean Delvare <jdelvare@...e.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	"H . Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] firmware: dmi: Correct an indexing error in dmi.h

On Sun, Dec 14, 2025 at 12:53:05PM -0600, Mario Limonciello (AMD) wrote:
> The entries later in `enum dmi_entry_type` don't match the SMBIOS
> specification.  The entry for type 33: `64-Bit Memory Error Information`
> is not present and thus the index for all later entries is incorrect.
> 
> Add the missing type 33 entry.

Types 43, 44, 45, and 46 are missing also. Should those be added as
well?

Probably not needed right now, but would be good to add them in a
future patch. I think there's precedent for keeping definitions up to
date with the spec even if they're not immediately used. ACPI does
this, I think.

> 
> Fixes: 93c890dbe5287 ("firmware: Add DMI entry types to the headers")
> Link: https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.4.0a.pdf
> Signed-off-by: Mario Limonciello (AMD) <superm1@...nel.org>

Reviewed-by: Yazen Ghannam <yazen.ghannam@....com>

Thanks,
Yazen