linux-kernel - Re: [PATCH v1 2/3] kexec: print out debugging message if required for kexec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <B86C6BDD7F4F1AC4+1b245d22-60ed-48d4-829e-aadfa145098f@uniontech.com>
Date: Mon, 15 Dec 2025 12:41:36 +0800
From: Qiang Ma <maqianga@...ontech.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: bhe@...hat.com, catalin.marinas@....com, will@...nel.org,
 kexec@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v1 2/3] kexec: print out debugging message if required for
 kexec_load


在 2025/12/15 08:32, Andrew Morton 写道:
> On Fri, 12 Dec 2025 17:56:48 +0800 Qiang Ma <maqianga@...ontech.com> wrote:
>
>> The commit a85ee18c7900 ("kexec_file: print out debugging message
>> if required") has added general code printing in kexec_file_load(),
>> but not in kexec_load().
>>
>> As a result, when using '-d' for the kexec_load interface,
>> print nothing in the kernel space.
> That doesn't sound like a thing which "kernel test robot" would detect
> and report.
>
>> Since the segments debugging message has already been printed by the
>> user-space tool kexec-tools, it will not be printed here in the
>> kernel space.
>>
>> And print out type/start/head of kimage and flags to help debug.
>>
>> Signed-off-by: Qiang Ma <maqianga@...ontech.com>
>> Reported-by: kernel test robot <lkp@...el.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202510310332.6XrLe70K-lkp@intel.com/
> Oh I see, that's a warning against an earlier version of this patch.
> But this is labelled "v1"!
yes.
>
> I suggest we remove this Reported-by record.
ok, I'll collect some other suggestions and fix it together in the next 
version.
>> --- a/kernel/kexec.c
>> +++ b/kernel/kexec.c
>> @@ -166,6 +166,9 @@ static int do_kexec_load(unsigned long entry, unsigned long nr_segments,
>>   	if (ret)
>>   		goto out;
>>   
>> +	kexec_dprintk("kexec_load: type:%u, start:0x%lx head:0x%lx flags:0x%lx\n",
>> +		      image->type, image->start, image->head, flags);
>> +
>>   	/* Install the new kernel and uninstall the old */
>>   	image = xchg(dest_image, image);
> Thanks, I'll await reviewer input before proceeding with this series.
>