lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5xlapgkp5bktan7xhy6l6b7c4qgeje7weu4cy6cbuux5npwijo@lhf5uvtuns5k>
Date: Mon, 15 Dec 2025 17:50:32 -0500
From: Aaron Tomlin <atomlin@...mlin.com>
To: "Moger, Babu" <bmoger@....com>
Cc: tony.luck@...el.com, reinette.chatre@...el.com, Dave.Martin@....com, 
	james.morse@....com, babu.moger@....com, tglx@...utronix.de, mingo@...hat.com, 
	bp@...en8.de, dave.hansen@...ux.intel.com, sean@...e.io, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] x86/resctrl: Add "*" shorthand to set minimum
 io_alloc CBM for all domains

On Fri, Dec 05, 2025 at 01:30:09PM -0600, Moger, Babu wrote:
> I feel this the lot of changes to take care of one extra character change. I
> feel code can be simplified to just this function.
> 
Hi Babu,

Thank you very much for following up and for providing a suggested
simplification of the code.

I appreciate you taking the time to review the changes. While your proposed
approach is definitely concise and functional, I prefer to maintain the
current, more elaborate implementation. The purpose of this slightly more
detailed structure is to improve overall readability and facilitate further
possible enhancements down the line.

For your information, in a subsequent patch series, I have decided to
refactor the logic within the main loop entirely. Specifically, I am
replacing the goto statement with a standard while loop to further improve
control flow and maintainability.


Kind regards,
-- 
Aaron Tomlin

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ