linux-kernel - Re: [RFC net-next v3 1/3] net: ethernet: mtk_eth_soc: Add register definitions for RSS and LRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9b7109cf-01d2-4dba-9e7b-7b94094ef4db@amd.com>
Date: Mon, 15 Dec 2025 15:39:08 -0800
From: "Creeley, Brett" <bcreeley@....com>
To: frank-w@...lic-files.de, Frank Wunderlich <linux@...web.de>,
 Felix Fietkau <nbd@....name>, Sean Wang <sean.wang@...iatek.com>,
 Lorenzo Bianconi <lorenzo@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Russell King <linux@...linux.org.uk>
Cc: Daniel Golle <daniel@...rotopia.org>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, Mason Chang <mason-cw.chang@...iatek.com>
Subject: Re: [RFC net-next v3 1/3] net: ethernet: mtk_eth_soc: Add register
 definitions for RSS and LRO

On 12/15/2025 11:57 AM, Frank Wunderlich wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> Am 15. Dezember 2025 20:28:36 MEZ schrieb "Creeley, Brett" <bcreeley@....com>:
>>
>> On 12/14/2025 3:03 AM, Frank Wunderlich wrote:
>>> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.h b/drivers/net/ethernet/mediatek/mtk_eth_soc.h
>>> index 0168e2fbc619..334625814b97 100644
>>> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.h
>>> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.h
>>> @@ -1143,16 +1143,30 @@ struct mtk_reg_map {
>>>           u32     tx_irq_mask;
>>>           u32     tx_irq_status;
>>>           struct {
>>> -               u32     rx_ptr;         /* rx base pointer */
>>> -               u32     rx_cnt_cfg;     /* rx max count configuration */
>>> -               u32     pcrx_ptr;       /* rx cpu pointer */
>>> -               u32     glo_cfg;        /* global configuration */
>>> -               u32     rst_idx;        /* reset index */
>>> -               u32     delay_irq;      /* delay interrupt */
>>> -               u32     irq_status;     /* interrupt status */
>>> -               u32     irq_mask;       /* interrupt mask */
>>> +               u32     rx_ptr;                 /* rx base pointer */
>>> +               u32     rx_cnt_cfg;             /* rx max count configuration */
>>> +               u32     pcrx_ptr;               /* rx cpu pointer */
>>> +               u32     pdrx_ptr;               /* rx dma pointer */
>>> +               u32     glo_cfg;                /* global configuration */
>>> +               u32     rst_idx;                /* reset index */
>>> +               u32     rx_cfg;                 /* rx dma configuration */
>>> +               u32     delay_irq;              /* delay interrupt */
>>> +               u32     irq_status;             /* interrupt status */
>>> +               u32     irq_mask;               /* interrupt mask */
>> Small nit - is the comment alignment really necessary?
> I could transform it to something like this:
>
> <https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/mediatek/mtk_eth_soc.h#n921>

I think it's okay as is. I was more concerned about the extra noise, but 
it's a pretty minimal change.

Brett

>
>> Thanks,
>>
>> Brett
>
> regards Frank
>