linux-kernel - Re: [PATCH v2 1/2] hung_task: Consolidate hung task warning into an atomic log block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <424sgc6khqv5seq3ppm5xw5l7n35x5yaygp4ltqfix74mshwmo@rtcxan4fwfrw>
Date: Mon, 15 Dec 2025 18:44:54 -0500
From: Aaron Tomlin <atomlin@...mlin.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: akpm@...ux-foundation.org, lance.yang@...ux.dev, mhiramat@...nel.org, 
	pmladek@...e.com, sean@...e.io, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] hung_task: Consolidate hung task warning into an
 atomic log block

On Thu, Dec 11, 2025 at 05:02:08PM +0900, Greg KH wrote:
> I'm all for moving this to a single function, but I'm not ok with
> multi-line messages in one pr_err() call like this, sorry.

Hi Greg,

Thank you for your feedback on the patch.

I agree with your assessment regarding the severity and the use of a single
pr_err() call for multi-line output. My previous description of this
message being "critical" was certainly an overstatement; this warning is
not more critical than an Oops or an OOM report, which also manage
multi-line output adequately. I will revert to the previous multi-line
implementation but will still consolidate the logic into the new helper
function and make some additional improvements to hopefully improve the
code structure and readability somewhat.

Kind regards,
-- 
Aaron Tomlin