Message-ID: <20251215051517.GB49936@system.software.com>
Date: Mon, 15 Dec 2025 14:15:17 +0900
From: Byungchul Park <byungchul@...com>
To: Jeff Layton <jlayton@...nel.org>
Cc: linux-kernel@...r.kernel.org, kernel_team@...ynix.com,
	torvalds@...ux-foundation.org, damien.lemoal@...nsource.wdc.com,
	linux-ide@...r.kernel.org, adilger.kernel@...ger.ca,
	linux-ext4@...r.kernel.org, mingo@...hat.com, peterz@...radead.org,
	will@...nel.org, tglx@...utronix.de, rostedt@...dmis.org,
	joel@...lfernandes.org, sashal@...nel.org, daniel.vetter@...ll.ch,
	duyuyang@...il.com, johannes.berg@...el.com, tj@...nel.org,
	tytso@....edu, willy@...radead.org, david@...morbit.com,
	amir73il@...il.com, gregkh@...uxfoundation.org, kernel-team@....com,
	linux-mm@...ck.org, akpm@...ux-foundation.org, mhocko@...nel.org,
	minchan@...nel.org, hannes@...xchg.org, vdavydov.dev@...il.com,
	sj@...nel.org, jglisse@...hat.com, dennis@...nel.org, cl@...ux.com,
	penberg@...nel.org, rientjes@...gle.com, vbabka@...e.cz,
	ngupta@...are.org, linux-block@...r.kernel.org,
	josef@...icpanda.com, linux-fsdevel@...r.kernel.org, jack@...e.cz,
	dan.j.williams@...el.com, hch@...radead.org, djwong@...nel.org,
	dri-devel@...ts.freedesktop.org, rodrigosiqueiramelo@...il.com,
	melissa.srw@...il.com, hamohammed.sa@...il.com,
	harry.yoo@...cle.com, chris.p.wilson@...el.com,
	gwan-gyeong.mun@...el.com, max.byungchul.park@...il.com,
	boqun.feng@...il.com, longman@...hat.com, yunseong.kim@...csson.com,
	ysk@...lloc.com, yeoreum.yun@....com, netdev@...r.kernel.org,
	matthew.brost@...el.com, her0gyugyu@...il.com, corbet@....net,
	catalin.marinas@....com, bp@...en8.de, x86@...nel.org,
	hpa@...or.com, luto@...nel.org, sumit.semwal@...aro.org,
	gustavo@...ovan.org, christian.koenig@....com,
	andi.shyti@...nel.org, arnd@...db.de, lorenzo.stoakes@...cle.com,
	Liam.Howlett@...cle.com, rppt@...nel.org, surenb@...gle.com,
	mcgrof@...nel.org, petr.pavlu@...e.com, da.gomez@...nel.org,
	samitolvanen@...gle.com, paulmck@...nel.org, frederic@...nel.org,
	neeraj.upadhyay@...nel.org, joelagnelf@...dia.com,
	josh@...htriplett.org, urezki@...il.com,
	mathieu.desnoyers@...icios.com, jiangshanlai@...il.com,
	qiang.zhang@...ux.dev, juri.lelli@...hat.com,
	vincent.guittot@...aro.org, dietmar.eggemann@....com,
	bsegall@...gle.com, mgorman@...e.de, vschneid@...hat.com,
	chuck.lever@...cle.com, neil@...wn.name, okorniev@...hat.com,
	Dai.Ngo@...cle.com, tom@...pey.com, trondmy@...nel.org,
	anna@...nel.org, kees@...nel.org, bigeasy@...utronix.de,
	clrkwllms@...nel.org, mark.rutland@....com, ada.coupriediaz@....com,
	kristina.martsenko@....com, wangkefeng.wang@...wei.com,
	broonie@...nel.org, kevin.brodsky@....com, dwmw@...zon.co.uk,
	shakeel.butt@...ux.dev, ast@...nel.org, ziy@...dia.com,
	yuzhao@...gle.com, baolin.wang@...ux.alibaba.com,
	usamaarif642@...il.com, joel.granados@...nel.org,
	richard.weiyang@...il.com, geert+renesas@...der.be,
	tim.c.chen@...ux.intel.com, linux@...blig.org,
	alexander.shishkin@...ux.intel.com, lillian@...r-ark.net,
	chenhuacai@...nel.org, francesco@...la.it,
	guoweikang.kernel@...il.com, link@...o.com, jpoimboe@...nel.org,
	masahiroy@...nel.org, brauner@...nel.org,
	thomas.weissschuh@...utronix.de, oleg@...hat.com, mjguzik@...il.com,
	andrii@...nel.org, wangfushuai@...du.com, linux-doc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
	linaro-mm-sig@...ts.linaro.org, linux-i2c@...r.kernel.org,
	linux-arch@...r.kernel.org, linux-modules@...r.kernel.org,
	rcu@...r.kernel.org, linux-nfs@...r.kernel.org,
	linux-rt-devel@...ts.linux.dev, 2407018371@...com, dakr@...nel.org,
	miguel.ojeda.sandonis@...il.com, neilb@...mail.net,
	bagasdotme@...il.com, wsa+renesas@...g-engineering.com,
	dave.hansen@...el.com, geert@...ux-m68k.org, ojeda@...nel.org,
	alex.gaynor@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com,
	lossin@...nel.org, a.hindborg@...nel.org, aliceryhl@...gle.com,
	tmgross@...ch.edu, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v18 41/42] SUNRPC: relocate struct rcu_head to the first
 field of struct rpc_xprt

On Fri, Dec 05, 2025 at 04:27:52AM -0500, Jeff Layton wrote:
> On Fri, 2025-12-05 at 16:18 +0900, Byungchul Park wrote:
> > While compiling Linux kernel with DEPT on, the following error was
> > observed:
> >
> >    ./include/linux/rcupdate.h:1084:17: note: in expansion of macro
> >    ‘BUILD_BUG_ON’
> >    1084 | BUILD_BUG_ON(offsetof(typeof(*(ptr)), rhf) >= 4096);        \
> >         | ^~~~~~~~~~~~
> >    ./include/linux/rcupdate.h:1047:29: note: in expansion of macro
> >    'kvfree_rcu_arg_2'
> >    1047 | #define kfree_rcu(ptr, rhf) kvfree_rcu_arg_2(ptr, rhf)
> >         |                             ^~~~~~~~~~~~~~~~
> >    net/sunrpc/xprt.c:1856:9: note: in expansion of macro 'kfree_rcu'
> >    1856 | kfree_rcu(xprt, rcu);
> >         | ^~~~~~~~~
> >     CC net/kcm/kcmproc.o
> >    make[4]: *** [scripts/Makefile.build:203: net/sunrpc/xprt.o] Error 1
> >
> > Since kfree_rcu() assumes 'offset of struct rcu_head in a rcu-managed
> > struct < 4096', the offest of struct rcu_head in struct rpc_xprt should
> > not exceed 4096 but does, due to the debug information added by DEPT.
> >
> > Relocate struct rcu_head to the first field of struct rpc_xprt from an
> > arbitrary location to avoid the issue and meet the assumption.
> >
> > Reported-by: Yunseong Kim <ysk@...lloc.com>
> > Signed-off-by: Byungchul Park <byungchul@...com>
> > ---
> >  include/linux/sunrpc/xprt.h | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/linux/sunrpc/xprt.h b/include/linux/sunrpc/xprt.h
> > index f46d1fb8f71a..666e42a17a31 100644
> > --- a/include/linux/sunrpc/xprt.h
> > +++ b/include/linux/sunrpc/xprt.h
> > @@ -211,6 +211,14 @@ enum xprt_transports {
> >
> >  struct rpc_sysfs_xprt;
> >  struct rpc_xprt {
> > +     /*
> > +      * Place struct rcu_head within the first 4096 bytes of struct
> > +      * rpc_xprt if sizeof(struct rpc_xprt) > 4096, so that
> > +      * kfree_rcu() can simply work assuming that.  See the comment
> > +      * in kfree_rcu().
> > +      */
> > +     struct rcu_head         rcu;
> > +
> >       struct kref             kref;           /* Reference count */
> >       const struct rpc_xprt_ops *ops;         /* transport methods */
> >       unsigned int            id;             /* transport id */
> > @@ -317,7 +325,6 @@ struct rpc_xprt {
> >  #if IS_ENABLED(CONFIG_SUNRPC_DEBUG)
> >       struct dentry           *debugfs;               /* debugfs directory */
> >  #endif
> > -     struct rcu_head         rcu;
> >       const struct xprt_class *xprt_class;
> >       struct rpc_sysfs_xprt   *xprt_sysfs;
> >       bool                    main; /*mark if this is the 1st transport */
> 
> Seems fine to me.
> 
> Reviewed-by: Jeff Layton <jlayton@...nel.org>

Thank you, Jeff.

	Byungchul

Powered by blists - more mailing lists