linux-kernel - Re: [PATCH 1/1] scsi: ufs: core: Fix error handler encryption support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aT-jjQpp1UfaiZIU@infradead.org>
Date: Sun, 14 Dec 2025 21:58:37 -0800
From: Christoph Hellwig <hch@...radead.org>
To: Bart Van Assche <bvanassche@....org>
Cc: Christoph Hellwig <hch@...radead.org>, Po-Wen Kao <powenkao@...gle.com>,
	Alim Akhtar <alim.akhtar@...sung.com>,
	Avri Altman <avri.altman@....com>,
	"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	"open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER" <linux-scsi@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] scsi: ufs: core: Fix error handler encryption support

On Wed, Dec 10, 2025 at 09:44:52AM -0800, Bart Van Assche wrote:
> On 12/9/25 10:48 PM, Christoph Hellwig wrote:
> > As mentioned last round, why are you even calling into the crypto
> > code here?  Calling that for a request without a crypt context,
> > which includes all of them that do not transfer any data makes no
> > sense to start with.
> 
> ufshcd_prepare_lrbp_crypto() only has one caller. Moving the new test
> from inside ufshcd_prepare_lrbp_crypto() into its caller should be easy.

I don't think callers vs calle is the important part here.  It is to
check if any actual data is tranferred instead of special casing EH
commands.