linux-kernel - Re: [PATCH] staging: rtl8723bs: Fix block comment coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aT-k12fYkV_FtoTW@stanley.mountain>
Date: Mon, 15 Dec 2025 09:04:07 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Zixuan Dong <dbeidachazi@...mail.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org, straube.linux@...il.com
Subject: Re: [PATCH] staging: rtl8723bs: Fix block comment coding style

On Mon, Dec 15, 2025 at 12:01:28PM +0800, Zixuan Dong wrote:
> Fix the following checkpatch warnings in os_intfs.c:
> 
>   WARNING: Block comments use * on subsequent lines
>   WARNING: Block comments use a trailing */ on a separate line
> 
> Signed-off-by: Zixuan Dong <dbeidachazi@...mail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/os_intfs.c | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index 6ca6dc548805..cd81d9e4a3d2 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -934,14 +934,16 @@ static int netdev_close(struct net_device *pnetdev)
>  	padapter->net_closed = true;
>  	padapter->netif_up = false;
>  
> -/*if (!padapter->hw_init_completed)
> -	{
> -
> -		padapter->bDriverStopped = true;
> -
> -		rtw_dev_unload(padapter);
> -	}
> -	else*/
> +/*
> + * if (!padapter->hw_init_completed)
> + * {
> + *
> + *	padapter->bDriverStopped = true;
> + *
> + *	rtw_dev_unload(padapter);
> + * }
> + * else
> + */

Just delete this dead code.

regards,
dan carpenter