linux-kernel - Re: [PATCH RFC] lib/tests: Convert test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdU-Dm9Z0hRPOyd67+mbd3xGxHHP-Eb6dB18BNs0hDcV0Q@mail.gmail.com>
Date: Mon, 15 Dec 2025 07:48:42 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Ryota Sakamoto <sakamo.ryota@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, David Gow <davidgow@...gle.com>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] lib/tests: Convert test_uuid module to KUnit

Hi Sakamoto-san,

Thanks for your patch!

On Sun, 14 Dec 2025 at 17:58, Ryota Sakamoto <sakamo.ryota@...il.com> wrote:
> Move lib/test_uuid.c to lib/tests/uuid_kunit.c and convert it to use KUnit.
>
> This change switches the ad-hoc test code to standard KUnit test cases.
> The test data remains the same, but the verification logic is updated
> to use KUNIT_EXPECT_* macros.
>
> Also remove CONFIG_TEST_UUID from arch/*/configs/* because the configs

This part is good...

> already defined CONFIG_KUNIT_ALL_TESTS so new CONFIG_UUID_KUNIT_TEST
> will be enabled by CONFIG_KUNIT_ALL_TESTS.

... but the reasoning here is not entirely correct: the old TEST_UUID
symbol is not auto-enabled, but its replacement (UUID_KUNIT_TEST) is.

> Signed-off-by: Ryota Sakamoto <sakamo.ryota@...il.com>

>  arch/m68k/configs/amiga_defconfig    |   1 -
>  arch/m68k/configs/apollo_defconfig   |   1 -
>  arch/m68k/configs/atari_defconfig    |   1 -
>  arch/m68k/configs/bvme6000_defconfig |   1 -
>  arch/m68k/configs/hp300_defconfig    |   1 -
>  arch/m68k/configs/mac_defconfig      |   1 -
>  arch/m68k/configs/multi_defconfig    |   1 -
>  arch/m68k/configs/mvme147_defconfig  |   1 -
>  arch/m68k/configs/mvme16x_defconfig  |   1 -
>  arch/m68k/configs/q40_defconfig      |   1 -
>  arch/m68k/configs/sun3_defconfig     |   1 -
>  arch/m68k/configs/sun3x_defconfig    |   1 -

For the above changes:
Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>

> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -3285,6 +3285,17 @@ config RATELIMIT_KUNIT_TEST
>
>           If unsure, say N.
>
> +config UUID_KUNIT_TEST
> +       tristate "KUnit test for UUID" if !KUNIT_ALL_TESTS
> +       depends on KUNIT
> +       default KUNIT_ALL_TESTS
> +       help
> +         This option enables the KUnit test suite for the uuid library,
> +         which provides functions for generating and parsing UUID and GUID.
> +         The test suite checks parsing of UUID and GUID strings.
> +
> +         If unsure, say N.
> +
>  config INT_POW_KUNIT_TEST
>         tristate "Integer exponentiation (int_pow) test" if !KUNIT_ALL_TESTS
>         depends on KUNIT

You forgot to remove the old TEST_UUID config option, which is no
longer used?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds