linux-kernel - Re: [PATCH v1 12/17] firmware: tee_bnxt: Make use of module_tee_client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aT-50by9eHqHQIYH@sumit-X1>
Date: Mon, 15 Dec 2025 16:33:37 +0900
From: Sumit Garg <sumit.garg@...nel.org>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Jens Wiklander <jens.wiklander@...aro.org>,
	Michael Chan <michael.chan@...adcom.com>,
	Pavan Chebbi <pavan.chebbi@...adcom.com>,
	Rafał Miłecki <zajec5@...il.com>,
	op-tee@...ts.trustedfirmware.org, netdev@...r.kernel.org,
	linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 12/17] firmware: tee_bnxt: Make use of
 module_tee_client_driver()

On Thu, Dec 11, 2025 at 06:15:06PM +0100, Uwe Kleine-König wrote:
> Reduce boilerplate by using the newly introduced module_tee_client_driver().
> That takes care of assigning the driver's bus, so the explicit assigning
> in this driver can be dropped.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> ---
>  drivers/firmware/broadcom/tee_bnxt_fw.c | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)

Reviewed-by: Sumit Garg <sumit.garg@....qualcomm.com>

-Sumit

> 
> diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
> index 40e3183a3d11..fbdf1aa97c82 100644
> --- a/drivers/firmware/broadcom/tee_bnxt_fw.c
> +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
> @@ -261,25 +261,13 @@ static struct tee_client_driver tee_bnxt_fw_driver = {
>  	.id_table	= tee_bnxt_fw_id_table,
>  	.driver		= {
>  		.name		= KBUILD_MODNAME,
> -		.bus		= &tee_bus_type,
>  		.probe		= tee_bnxt_fw_probe,
>  		.remove		= tee_bnxt_fw_remove,
>  		.shutdown	= tee_bnxt_fw_shutdown,
>  	},
>  };
>  
> -static int __init tee_bnxt_fw_mod_init(void)
> -{
> -	return driver_register(&tee_bnxt_fw_driver.driver);
> -}
> -
> -static void __exit tee_bnxt_fw_mod_exit(void)
> -{
> -	driver_unregister(&tee_bnxt_fw_driver.driver);
> -}
> -
> -module_init(tee_bnxt_fw_mod_init);
> -module_exit(tee_bnxt_fw_mod_exit);
> +module_tee_client_driver(tee_bnxt_fw_driver);
>  
>  MODULE_AUTHOR("Vikas Gupta <vikas.gupta@...adcom.com>");
>  MODULE_DESCRIPTION("Broadcom bnxt firmware manager");
> -- 
> 2.47.3
>