linux-kernel - Re: [PATCH 1/2] dt-bindings: power: fsl,imx-gpc: Document address-cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12807757.O9o76ZdvQC@steina-w>
Date: Mon, 15 Dec 2025 08:31:47 +0100
From: Alexander Stein <alexander.stein@...tq-group.com>
To: Frank Li <Frank.li@....com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Philipp Zabel <p.zabel@...gutronix.de>,
 devicetree@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject:
 Re: [PATCH 1/2] dt-bindings: power: fsl,imx-gpc: Document address-cells

Hi,

Am Freitag, 12. Dezember 2025, 18:02:32 CET schrieb Frank Li:
> On Fri, Dec 12, 2025 at 09:58:59AM +0100, Alexander Stein wrote:
> > The GPC power controller is an interrupt controllers and can be referenced
> > in interrupt-map properties, e.g. PCIe controller, thus the node should
> > have address-cells property.
> >
> > Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> 
> Strange, there are not #address-cells property for gic if there are not
> ITS node. gic is widely used.
> 
> Does gic node also missed #address-cells?

Yes and no.
Yes: see commit faf183a02ed6b ("arm64: dts: imx8mp: Add default GIC address cells")
No: AFAICS this is only necessary if an interrupt-controller is referenced
from within interrupt-map. But on imx6qdl.dtsi 'intc' (GIC) is not used that way.

Best regards,
Alexander

> 
> Frank
> 
> > ---
> >  Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
> > index 9de3fe73c1eb6..d49a5130b87c7 100644
> > --- a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
> > +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
> > @@ -38,6 +38,9 @@ properties:
> >    reg:
> >      maxItems: 1
> >
> > +  "#address-cells":
> > +    const: 0
> > +
> >    interrupts:
> >      maxItems: 1
> >
> > --
> > 2.43.0
> >
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)