linux-kernel - Re: [PATCH] vfs: fix EBUSY on FSCONFIG_CMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC1kPDMrF_vZAbPatzgQP_RDowCwOpBV71V1acv5VpogWuhzXg@mail.gmail.com>
Date: Mon, 15 Dec 2025 16:55:46 +0800
From: Chen Linxuan <me@...ck-desk.cn>
To: Jan Kara <jack@...e.cz>
Cc: me@...ck-desk.cn, Alexander Viro <viro@...iv.linux.org.uk>, 
	Christian Brauner <brauner@...nel.org>, linux-fsdevel@...r.kernel.org, 
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] vfs: fix EBUSY on FSCONFIG_CMD_CREATE retry

On Mon, Dec 15, 2025 at 4:46 PM Jan Kara <jack@...e.cz> wrote:
>
> On Sat 13-12-25 02:03:56, Chen Linxuan via B4 Relay wrote:
> > If the syscall is restarted, fsconfig() is called again and retrieves
> > the *same* fs_context. However, vfs_cmd_create() rejects the call
> > because the phase was left as FS_CONTEXT_CREATING during the first
> > attempt:
>
> Well, not quite. The phase is actually set to FS_CONTEXT_FAILED if
> vfs_get_tree() returns any error. Still the effect is the same.

Oh, that's a mistake.

> Thanks for the patch. It looks good to me. I'd slightly prefer style like:
>
>         if (ret) {
>                 if (ret == -ERESTARTNOINTR)
>                         fc->phase = FS_CONTEXT_CREATE_PARAMS;
>                 else
>                         fc->phase = FS_CONTEXT_FAILED;
>                 return ret;
>         }

Will be applied in v2.