linux-kernel - Re: [PATCH] mfd: arizona: Fix regulator resource leak on wm5102_clear_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aT/TfpcFedLntO4Z@opensource.cirrus.com>
Date: Mon, 15 Dec 2025 09:23:10 +0000
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Haotian Zhang <vulab@...as.ac.cn>
Cc: lee@...nel.org, ckeepax@...nsource.wolfsonmicro.com,
        patches@...nsource.cirrus.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: arizona: Fix regulator resource leak on
 wm5102_clear_write_sequencer failure

On Sun, Dec 14, 2025 at 10:58:03PM +0800, Haotian Zhang wrote:
> The wm5102_clear_write_sequencer() helper may return an error
> and just return, bypassing the cleanup sequence and causing
> regulators to remain enabled, leading to a resource leak.
> 
> Change the direct return to jump to the err_reset label to
> properly free the resources.
> 
> Fixes: 1c1c6bba57f5 ("mfd: wm5102: Ensure we always boot the device fully")
> Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>
> ---

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles