linux-kernel - Re: [PATCH] modules: moduleparam.h: add kernel-doc comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86018f05-1be3-46c9-a983-31cf677a4933@suse.com>
Date: Mon, 15 Dec 2025 11:59:14 +0100
From: Petr Pavlu <petr.pavlu@...e.com>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: Luis Chamberlain <mcgrof@...nel.org>, Daniel Gomez <da.gomez@...nel.org>,
 Sami Tolvanen <samitolvanen@...gle.com>, linux-modules@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] modules: moduleparam.h: add kernel-doc comments

On 12/14/25 9:23 PM, Randy Dunlap wrote:
> Add missing kernel-doc comments to prevent kernel-doc warnings:
> 
> Warning: include/linux/moduleparam.h:364 function parameter 'arg' not
>  described in '__core_param_cb'
> Warning: include/linux/moduleparam.h:395 No description found for return
>  value of 'parameq'
> Warning: include/linux/moduleparam.h:405 No description found for return
>  value of 'parameqn'
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>

Nit: The description is somewhat misleading as it mentions adding
kernel-doc comments, but the patch actually involves fixing the existing
comments. I guess this can be adjusted by a maintainer who picks up the
patch and there is no need to resend it.

Looks ok to me otherwise.

Reviewed-by: Petr Pavlu <petr.pavlu@...e.com>

-- 
Thanks,
Petr