linux-kernel - RE: [PATCH] remoteproc: imx_rproc: Use strstarts for "rsc-table" check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8459542CF892C802061E162688ADA@PAXPR04MB8459.eurprd04.prod.outlook.com>
Date: Mon, 15 Dec 2025 11:11:47 +0000
From: Peng Fan <peng.fan@....com>
To: Mathieu Poirier <mathieu.poirier@...aro.org>, Shenwei Wang
	<shenwei.wang@....com>
CC: Bjorn Andersson <andersson@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team
	<kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>,
	"linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH] remoteproc: imx_rproc: Use strstarts for "rsc-table"
 check

> Subject: Re: [PATCH] remoteproc: imx_rproc: Use strstarts for "rsc-
> table" check
> 
> On Mon, Dec 08, 2025 at 05:33:02PM -0600, Shenwei Wang wrote:
> > The resource name may include an address suffix, for example:
> > rsc-table@...f8000.
> >
> > To handle such cases, use strstarts() instead of strcmp() when
> > checking for "rsc-table".
> >
> > Signed-off-by: Shenwei Wang <shenwei.wang@....com>
> > ---
> >  drivers/remoteproc/imx_rproc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/remoteproc/imx_rproc.c
> > b/drivers/remoteproc/imx_rproc.c index
> 3be8790c14a2..33f21ab24c92
> > 100644
> > --- a/drivers/remoteproc/imx_rproc.c
> > +++ b/drivers/remoteproc/imx_rproc.c
> > @@ -694,7 +694,7 @@ static int imx_rproc_addr_init(struct
> imx_rproc *priv,
> >  		}
> >  		priv->mem[b].sys_addr = res.start;
> >  		priv->mem[b].size = resource_size(&res);
> > -		if (!strcmp(res.name, "rsc-table"))
> > +		if (strstarts(res.name, "rsc-table"))
> >  			priv->rsc_table = priv->mem[b].cpu_addr;
> 
> Before applying this patch, I want to know how it ever worked before.
> How did DT with a suffix tested?

In Rob's v2 version[1], I gave my T-b in 2025-5-7, but I could not recall
whether I did rpmsg test, seems I only did start/stop test from the issue
Shenwei spotted.

[1] https://lore.kernel.org/linux-remoteproc/20250423-dt-memory-region-v2-v2-4-2fbd6ebd3c88@kernel.org/

Regards
Peng.

> 
> >  		b++;
> >  	}
> > --
> > 2.43.0
> >