linux-kernel - Re: [PATCH] NFC: Fix error handling in nfc_genl_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <624c7965-54cd-4897-9883-c8f4e79d3ca7@kernel.org>
Date: Mon, 15 Dec 2025 12:28:39 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ma Ke <make24@...as.ac.cn>, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
 aloisio.almeida@...nbossa.org, lauro.venancio@...nbossa.org,
 sameo@...ux.intel.com, linville@...driver.com, johannes@...solutions.net
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 akpm@...ux-foundation.org, stable@...r.kernel.org
Subject: Re: [PATCH] NFC: Fix error handling in nfc_genl_dump_targets

On 14/12/2025 14:17, Ma Ke wrote:
> nfc_genl_dump_targets() increments the device reference count via
> nfc_get_device() but fails to decrement it properly. nfc_get_device()
> calls class_find_device() which internally calls get_device() to
> increment the reference count. No corresponding put_device() is made
> to decrement the reference count.
> 
> Add proper reference count decrementing using nfc_put_device() when
> the dump operation completes or encounters an error, ensuring balanced
> reference counting.
> 
> Found by code review.


NAK, you completely ignore reviewers and send the same. That's not
acceptable.

Best regards,
Krzysztof