linux-kernel - Re: [PATCH v6 2/5] arm64: dts: qcom: Add sdhc dll-presets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f7c0d5c-7f77-4669-9648-62d008f15b1c@kernel.org>
Date: Mon, 15 Dec 2025 13:05:08 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ram Prakash Gupta <quic_rampraka@...cinc.com>,
 Ulf Hansson <ulf.hansson@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>,
 Adrian Hunter <adrian.hunter@...el.com>
Cc: linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 dmitry.baryshkov@....qualcomm.com, quic_pragalla@...cinc.com,
 quic_sayalil@...cinc.com, quic_nitirawa@...cinc.com,
 quic_bhaskarv@...cinc.com, kernel@....qualcomm.com
Subject: Re: [PATCH v6 2/5] arm64: dts: qcom: Add sdhc dll-presets

On 15/12/2025 13:00, Ram Prakash Gupta wrote:
> Add sdhc dll-presets for qdu1000 target.
> 
> Signed-off-by: Ram Prakash Gupta <quic_rampraka@...cinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qdu1000.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

> 
> diff --git a/arch/arm64/boot/dts/qcom/qdu1000.dtsi b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
> index 846e5e5899aa..bc31504d5c8c 100644
> --- a/arch/arm64/boot/dts/qcom/qdu1000.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
> @@ -912,8 +912,8 @@ sdhc: mmc@...4000 {
>  
>  			bus-width = <8>;
>  
> -			qcom,dll-config = <0x0007642c>;
> -			qcom,ddr-config = <0x80040868>;
> +			qcom,dll-presets = <0x000F64EC 0x0 0x01	0x2C010800 0x80040868>,
> +					   <0x0007642C 0x0 0x10 0x2C010800 0x80040868>;


That's non-bisectable. You just broke the users of this DTS. Also, case
change is not explained and your binding said nothing about deprecating
other properties.


Best regards,
Krzysztof