linux-kernel - Re: [PATCH v6 1/5] dt-bindings: mmc: Add dll-presets values for HS400 and HS200 modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03819cd6-9f19-4c28-806b-17c7596e5299@kernel.org>
Date: Mon, 15 Dec 2025 13:06:22 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ram Prakash Gupta <quic_rampraka@...cinc.com>,
 Ulf Hansson <ulf.hansson@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>,
 Adrian Hunter <adrian.hunter@...el.com>
Cc: linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 dmitry.baryshkov@....qualcomm.com, quic_pragalla@...cinc.com,
 quic_sayalil@...cinc.com, quic_nitirawa@...cinc.com,
 quic_bhaskarv@...cinc.com, kernel@....qualcomm.com,
 Sachin Gupta <quic_sachgupt@...cinc.com>
Subject: Re: [PATCH v6 1/5] dt-bindings: mmc: Add dll-presets values for HS400
 and HS200 modes

On 15/12/2025 13:00, Ram Prakash Gupta wrote:
> From: Sachin Gupta <quic_sachgupt@...cinc.com>
> 
> Document the 'dll-presets' property for MMC device tree bindings.
> The 'dll-presets' property defines the DLL configurations for HS400
> and HS200 modes.
> 
> QC SoCs can have 0 to 4 SDHCI instances, and each one may need
> different tuning.
> 
> Signed-off-by: Sachin Gupta <quic_sachgupt@...cinc.com>
> Signed-off-by: Ram Prakash Gupta <quic_rampraka@...cinc.com>
> ---
>  Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> index 938be8228d66..a1a16e6e12ce 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> @@ -140,6 +140,11 @@ properties:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      description: platform specific settings for DLL_CONFIG reg.
>  
> +  qcom,dll-presets:
> +    maxItems: 10
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    description: platform specific settings for DLL registers.


So look at your DTS - this is clearly incomplete now. So obvious. I
don't understand why you were hiding the DTS change, you just make
review more difficult.

Anyway, your DTS says you replace some other DLL properties and nothing
in the binding or commit msg explains that. Neither the reason nor the
impact.

Best regards,
Krzysztof