linux-kernel - Re: [PATCH] firmware: cs_dsp: Don't use __free() in cs_dsp_load() and cs_dsp_load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <176580710392.161056.10162316021978707738.b4-ty@kernel.org>
Date: Mon, 15 Dec 2025 22:58:23 +0900
From: Mark Brown <broonie@...nel.org>
To: Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org, 
 patches@...nsource.cirrus.com
Subject: Re: [PATCH] firmware: cs_dsp: Don't use __free() in cs_dsp_load()
 and cs_dsp_load_coeff()

On Mon, 01 Dec 2025 16:07:29 +0000, Richard Fitzgerald wrote:
> Replace the __free(kfree) in cs_dsp_load() and cs_dsp_load_coeff() with
> a kfree(buf) at the end of the function.
> 
> The use of __free() can create new cleanup bugs that are difficult to spot
> because the defective code is idiomatically correct regular C. In these two
> functions the __free() was mixed with gotos, and also used the suspect
> declaration __free(kfree) = NULL;.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] firmware: cs_dsp: Don't use __free() in cs_dsp_load() and cs_dsp_load_coeff()
      commit: ae9ccaed3f6701ee0fe40ad919516e0aa0844f21

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark