linux-kernel - Re: [PATCH 0/6] ASoC: qcom: Fix confusing cleanup.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <176580710495.161056.18321549435251092606.b4-ty@kernel.org>
Date: Mon, 15 Dec 2025 22:58:24 +0900
From: Mark Brown <broonie@...nel.org>
To: Srinivas Kandagatla <srini@...nel.org>, 
 Liam Girdwood <lgirdwood@...il.com>, Jaroslav Kysela <perex@...ex.cz>, 
 Takashi Iwai <tiwai@...e.com>, 
 Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
Cc: linux-sound@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/6] ASoC: qcom: Fix confusing cleanup.h

On Sat, 29 Nov 2025 14:17:52 +0100, Krzysztof Kozlowski wrote:
> Please, please stop ending cleanup.h patches for very simple code like:
> 
>   foo = kzalloc();
>   kfree(foo);
>   return;
> 
> ... *if you do not intend to read cleanup.h*. These changes are making
> simple code not necessarily simpler. But worse, if you do not read
> cleanup.h then you introduce actually undesired, error-prone and wrong
> style of having constructors with redundant values (= NULL).
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/6] ASoC: qcom: q6prm: Fix confusing cleanup.h syntax
      commit: bd9e7182e36169cd7e1ea3b25b5c82b1c5698e64
[2/6] ASoC: qcom: q6asm: Fix confusing cleanup.h syntax
      commit: c862dc9019f517893eb83096076d7eed4ecbb372
[3/6] ASoC: qcom: q6apm: Fix confusing cleanup.h syntax
      commit: 310e6f95eedaae04990072078adbb38beb149811
[4/6] ASoC: qcom: q6afe: Fix confusing cleanup.h syntax
      commit: 3c84bfa47ff29ec0c202cb139d365421c6778d65
[5/6] ASoC: qcom: audioreach: Fix confusing cleanup.h syntax
      commit: 0e6071d656fb284e003a45ce158831d4d12aac5a
[6/6] ASoC: qcom: Minor readability improve with new lines
      commit: 0bb160c92ad400c692984763996b758458adea17

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark