linux-kernel - Re: [PATCH] sched_ext: Remove unused code in the do_pick_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aUAUAP9micR5F9oj@gpd4>
Date: Mon, 15 Dec 2025 14:58:24 +0100
From: Andrea Righi <arighi@...dia.com>
To: Zqiang <qiang.zhang@...ux.dev>
Cc: tj@...nel.org, void@...ifault.com, changwoo@...lia.com,
	sched-ext@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched_ext: Remove unused code in the do_pick_task_scx()

On Mon, Dec 15, 2025 at 07:29:40PM +0800, Zqiang wrote:
> The kick_idle variable is no longer used, this commit therefore remove
> it and also remove associated code in the do_pick_task_scx().
> 
> Fixes: 4c95380701f5 ("sched/ext: Fold balance_scx() into pick_task_scx()"),

nit: drop the comma at the end of the line.

Apart than that, looks good to me, thanks for the cleanup.

Reviewed-by: Andrea Righi <arighi@...dia.com>

-Andrea

> Signed-off-by: Zqiang <qiang.zhang@...ux.dev>
> ---
>  kernel/sched/ext.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
> index 695503a2f7d1..94164f2dec6d 100644
> --- a/kernel/sched/ext.c
> +++ b/kernel/sched/ext.c
> @@ -2446,7 +2446,7 @@ static struct task_struct *
>  do_pick_task_scx(struct rq *rq, struct rq_flags *rf, bool force_scx)
>  {
>  	struct task_struct *prev = rq->curr;
> -	bool keep_prev, kick_idle = false;
> +	bool keep_prev;
>  	struct task_struct *p;
>  
>  	/* see kick_cpus_irq_workfn() */
> @@ -2488,12 +2488,8 @@ do_pick_task_scx(struct rq *rq, struct rq_flags *rf, bool force_scx)
>  			refill_task_slice_dfl(rcu_dereference_sched(scx_root), p);
>  	} else {
>  		p = first_local_task(rq);
> -		if (!p) {
> -			if (kick_idle)
> -				scx_kick_cpu(rcu_dereference_sched(scx_root),
> -					     cpu_of(rq), SCX_KICK_IDLE);
> +		if (!p)
>  			return NULL;
> -		}
>  
>  		if (unlikely(!p->scx.slice)) {
>  			struct scx_sched *sch = rcu_dereference_sched(scx_root);
> -- 
> 2.17.1
>