linux-kernel - Re: [PATCH RFC net-next 06/13] dpll: Support dynamic pin index allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31e2a687-7e5d-40f2-ba5a-0c05db10e5ae@redhat.com>
Date: Mon, 15 Dec 2025 15:43:52 +0100
From: Ivan Vecera <ivecera@...hat.com>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
 Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
 Grzegorz Nitka <grzegorz.nitka@...el.com>, Jiri Pirko <jiri@...nulli.us>,
 Petr Oros <poros@...hat.com>, Michal Schmidt <mschmidt@...hat.com>,
 Prathosh Satish <Prathosh.Satish@...rochip.com>,
 Tony Nguyen <anthony.l.nguyen@...el.com>, Saeed Mahameed
 <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>,
 Tariq Toukan <tariqt@...dia.com>, Mark Bloch <mbloch@...dia.com>,
 Richard Cochran <richardcochran@...il.com>,
 Jonathan Lemon <jonathan.lemon@...il.com>, Simon Horman <horms@...nel.org>,
 Alexander Lobakin <aleksander.lobakin@...el.com>,
 Willem de Bruijn <willemb@...gle.com>, Stefan Wahren <wahrenst@....net>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 intel-wired-lan@...ts.osuosl.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH RFC net-next 06/13] dpll: Support dynamic pin index
 allocation

On 12/15/25 3:10 PM, Przemek Kitszel wrote:
> On 12/11/25 20:47, Ivan Vecera wrote:
>> Allow drivers to register DPLL pins without manually specifying a pin
>> index.
>>
>> Currently, drivers must provide a unique pin index when calling
>> dpll_pin_get(). This works well for hardware-mapped pins but creates
>> friction for drivers handling virtual pins or those without a strict
>> hardware indexing scheme.
> 
> wouldn't it be better to just switch everything to allocated IDs?
> 
No, this would break original dpll_pin_get() logic. If a caller use
dynamic pin index allocation then in practice means that a new pin
is allocated. But if I have a HW pin with specific index then I want
to get the same ref-counted dpll_pin pointer by dpll_pin_get().

Ivan