linux-kernel - Re: [PATCH v3] xtensa: align: validate access in fast_load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMo8BfKsh3N-tGfKpEXfKvGjO8L_GmBVpwh10BOXd7DfsScyHg@mail.gmail.com>
Date: Mon, 15 Dec 2025 07:11:53 -0800
From: Max Filippov <jcmvbkbc@...il.com>
To: Ricky Ringler <richard.rringler@...il.com>
Cc: Chris Zankel <chris@...kel.net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] xtensa: align: validate access in fast_load_store

On Mon, Dec 15, 2025 at 6:33 AM Ricky Ringler
<richard.rringler@...il.com> wrote:
>
> access_ok() is used only in user mode and
> branches to .Linvalid_instruction on fault.
> Kernel mode skips access_ok().
>
> Tested-by: Ricky Ringler <richard.rringler@...il.com>
>
> Signed-off-by: Ricky Ringler <richard.rringler@...il.com>
> ---
> v3:
> - Changed kernel mode behavior to skip access_ok()
>
> v2:
> - Address Max's feedback
> - Fixed formatting
> - Added user mode branch
>
> Testing:
> - Built with CONFIG_MMU enabled
> - objdump before/after comparison and validated code path
>
>  arch/xtensa/kernel/align.S | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)

Thanks. Applied to my xtensa tree.
-- Max