linux-kernel - Re: [PATCH v3 2/3] gpu: nova-core: select RUST_FW_LOADER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DEZPQLO5LNME.2DX0F8PX3DW9Y@nvidia.com>
Date: Tue, 16 Dec 2025 23:32:58 +0900
From: "Alexandre Courbot" <acourbot@...dia.com>
To: "Alexandre Courbot" <acourbot@...dia.com>, "Alyssa Ross" <hi@...ssa.is>
Cc: "Luis Chamberlain" <mcgrof@...nel.org>, "Russ Weight"
 <russ.weight@...ux.dev>, "Danilo Krummrich" <dakr@...nel.org>, "Greg
 Kroah-Hartman" <gregkh@...uxfoundation.org>, "Rafael J. Wysocki"
 <rafael@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>, "Simona Vetter"
 <simona@...ll.ch>, "Andrew Lunn" <andrew@...n.ch>, "Heiner Kallweit"
 <hkallweit1@...il.com>, "Russell King" <linux@...linux.org.uk>, "David S.
 Miller" <davem@...emloft.net>, "Eric Dumazet" <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, "Paolo Abeni" <pabeni@...hat.com>, "Miguel
 Ojeda" <ojeda@...nel.org>, "Alex Gaynor" <alex.gaynor@...il.com>, "Boqun
 Feng" <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Benno Lossin"
 <lossin@...nel.org>, "Andreas Hindborg" <a.hindborg@...nel.org>, "Trevor
 Gross" <tmgross@...ch.edu>, "FUJITA Tomonori" <fujita.tomonori@...il.com>,
 <linux-kernel@...r.kernel.org>, <nouveau@...ts.freedesktop.org>,
 <dri-devel@...ts.freedesktop.org>, <netdev@...r.kernel.org>,
 <rust-for-linux@...r.kernel.org>
Subject: Re: [PATCH v3 2/3] gpu: nova-core: select
 RUST_FW_LOADER_ABSTRACTIONS

On Tue Dec 16, 2025 at 2:24 PM JST, Alexandre Courbot wrote:
> On Mon Dec 15, 2025 at 11:59 PM JST, Alyssa Ross wrote:
>> On Thu, Nov 06, 2025 at 11:40:55AM +0900, Alexandre Courbot wrote:
>>> RUST_FW_LOADER_ABSTRACTIONS was depended on by NOVA_CORE, but NOVA_CORE
>>> is selected by DRM_NOVA. This creates a situation where, if DRM_NOVA is
>>> selected, NOVA_CORE gets enabled but not RUST_FW_LOADER_ABSTRACTIONS,
>>> which results in a build error.
>>>
>>> Since the firmware loader is an implementation detail of the driver, it
>>> should be enabled along with it, so change the "depends on" to a
>>> "select".
>>>
>>> Fixes: 54e6baf123fd ("gpu: nova-core: add initial driver stub")
>>> Signed-off-by: Alexandre Courbot <acourbot@...dia.com>
>>> ---
>>
>> I just encountered this testing 6.19-rc1, and was pleased to discover
>> this patch had already been submitted.
>>
>> Tested-by: Alyssa Ross <hi@...ssa.is>
>>
>> And it probably also makes sense to add this now that the kernel test
>> robot has also found it:
>>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202512061721.rxKGnt5q-lkp@intel.com/
>
> Thanks! Both tags added.
>
>>
>> (I suppose it doesn't make sense to add the Reported-by suggested there
>> since your patch predates that report.)
>>
>> I see that the first patch from this series has already been picked up
>> by Greg, but this and patch 3 are still waiting.  Is that correct?
>
> After rebasing on top of -rc1, I can confirm. This patch is going to be
> taken through the Nova tree. Patch 3 is available for the relevant
> maintainers to take.

Pushed this patch with added taggs and Danilo's Acked-by (received on
Zulip) to drm-rust-fixes, thanks!