linux-kernel - Re: [PATCH v5 1/3] x86/mm/tlb: Make enter_lazy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251216154951.631-1-qq570070308@gmail.com>
Date: Tue, 16 Dec 2025 23:49:51 +0800
From: Xie Yuanbin <qq570070308@...il.com>
To: tglx@...utronix.de
Cc: acme@...nel.org,
	adrian.hunter@...el.com,
	agordeev@...ux.ibm.com,
	akpm@...ux-foundation.org,
	alex@...ti.fr,
	alexander.shishkin@...ux.intel.com,
	andreas@...sler.com,
	anshuman.khandual@....com,
	aou@...s.berkeley.edu,
	arnd@...db.de,
	borntraeger@...ux.ibm.com,
	bp@...en8.de,
	bsegall@...gle.com,
	dave.hansen@...ux.intel.com,
	davem@...emloft.net,
	david@...nel.org,
	dietmar.eggemann@....com,
	frederic@...nel.org,
	gor@...ux.ibm.com,
	hca@...ux.ibm.com,
	hpa@...or.com,
	irogers@...gle.com,
	james.clark@...aro.org,
	jolsa@...nel.org,
	juri.lelli@...hat.com,
	justinstitt@...gle.com,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	linux-perf-users@...r.kernel.org,
	linux-riscv@...ts.infradead.org,
	linux-s390@...r.kernel.org,
	linux@...linux.org.uk,
	llvm@...ts.linux.dev,
	lorenzo.stoakes@...cle.com,
	luto@...nel.org,
	mark.rutland@....com,
	mathieu.desnoyers@...icios.com,
	max.kellermann@...os.com,
	mgorman@...e.de,
	mingo@...hat.com,
	morbo@...gle.com,
	namhyung@...nel.org,
	nathan@...nel.org,
	nick.desaulniers+lkml@...il.com,
	nysal@...ux.ibm.com,
	palmer@...belt.com,
	paulmck@...nel.org,
	peterz@...radead.org,
	pjw@...nel.org,
	qq570070308@...il.com,
	riel@...riel.com,
	rostedt@...dmis.org,
	ryan.roberts@....com,
	segher@...nel.crashing.org,
	sparclinux@...r.kernel.org,
	svens@...ux.ibm.com,
	thuth@...hat.com,
	urezki@...il.com,
	vincent.guittot@...aro.org,
	vschneid@...hat.com,
	x86@...nel.org
Subject: Re: [PATCH v5 1/3] x86/mm/tlb: Make enter_lazy_tlb() always inline on x86

On Mon, 15 Dec 2025 16:42:13 +0100, Thomas Gleixner wrote:
> These Reported-by and Closes tags are just wrong. This is a new patch
> and the robot reported failures against earlier versions. The robot
> report is very clear about that:
>
>   "If you fix the issue in a separate patch/commit (i.e. not just a new version of
>    the same patch/commit), kindly add following tags
>      Reported-by:...
>      Closes:..."
>
> No?
>
> [...]
>
> Please move the '#define enter_....' under the inline function. That's
> way simpler to read.

Thanks for replying, I will improve it in the V6 patch.

>> +/*
>> + * Please ignore the name of this function.  It should be called
>> + * switch_to_kernel_thread().
>
> And why is it not renamed then?
>
>> + *
>> + * enter_lazy_tlb() is a hint from the scheduler that we are entering a
>
> We enter a kernel thread? AFAIK the metaverse has been canceled.
>
>> + * kernel thread or other context without an mm.  Acceptable implementations
>> + * include doing nothing whatsoever, switching to init_mm, or various clever
>> + * lazy tricks to try to minimize TLB flushes.
>> + *
>> + * The scheduler reserves the right to call enter_lazy_tlb() several times
>> + * in a row.  It will notify us that we're going back to a real mm by
>
> It will notify us by sending email or what?

I didn't write any comments, I just moved its location.

As for the content of the comment, I think it has nothing to do with this
patch. If the content of the comment needs to be modified, it should be
modified in another patch?

Thanks!