linux-kernel - Re: [PATCH v16 12/17] rust: sync: lock/global: Rename B to G in trait bounds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <08d00540-9de9-43a5-9e36-df2d575b4c24@gmail.com>
Date: Tue, 16 Dec 2025 17:15:18 +0100
From: Dirk Behme <dirk.behme@...il.com>
To: Lyude Paul <lyude@...hat.com>, rust-for-linux@...r.kernel.org,
 linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>
Cc: Boqun Feng <boqun.feng@...il.com>,
 Daniel Almeida <daniel.almeida@...labora.com>,
 Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Gary Guo <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, Benno Lossin <lossin@...nel.org>,
 Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Will Deacon <will@...nel.org>, Waiman Long <longman@...hat.com>
Subject: Re: [PATCH v16 12/17] rust: sync: lock/global: Rename B to G in trait
 bounds

On 15.12.25 18:57, Lyude Paul wrote:
> Due to the introduction of Backend::BackendInContext, if we want to be able
> support Lock types with a Context we need to be able to handle the fact
> that the Backend for a returned Guard may not exactly match the Backend for
> the lock. Before we add this though, rename B to G in all of our trait
> bounds to make sure things don't become more difficult to understand once
> we add a Backend bound.
> 
> There should be no functional changes in this patch.
> 
> Signed-off-by: Lyude Paul <lyude@...hat.com>
> ---
>  rust/kernel/sync/atomic.rs      |  2 +-
>  rust/kernel/sync/lock/global.rs | 58 ++++++++++++++++-----------------
>  2 files changed, 30 insertions(+), 30 deletions(-)
> 
> diff --git a/rust/kernel/sync/atomic.rs b/rust/kernel/sync/atomic.rs
> index 3afc376be42d9..c07a53f8360b4 100644
> --- a/rust/kernel/sync/atomic.rs
> +++ b/rust/kernel/sync/atomic.rs
> @@ -21,8 +21,8 @@
>  mod predefine;
>  
>  pub use internal::AtomicImpl;
> -pub use ordering::{Acquire, Full, Relaxed, Release};
>  pub(crate) use internal::{AtomicArithmeticOps, AtomicBasicOps, AtomicExchangeOps};
> +pub use ordering::{Acquire, Full, Relaxed, Release};

Just fyi, there is a (trivial) conflict of this with Miguel's recently
merged

commit 309e49039f124a ("rust: sync: atomic: separate import "blocks"")
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/rust/kernel/sync/atomic.rs?id=309e49039f124a9dcb99c05651af8eb8fa05bc29

If I haven't missed anything this is just to fix the alphabetical
order? So maybe this should go as an independent patch like Miguel's one?

Dirk