linux-kernel - Re: [PATCH v3 4/4] LoongArch: ftrace: Adjust register stack restore order in direct call trampolines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251216121149.11ea9031@gandalf.local.home>
Date: Tue, 16 Dec 2025 12:11:49 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Chenghao Duan <duanchenghao@...inos.cn>
Cc: yangtiezhu@...ngson.cn, mhiramat@...nel.org, mark.rutland@....com,
 hengqi.chen@...il.com, chenhuacai@...nel.org, kernel@...0n.name,
 zhangtianyang@...ngson.cn, masahiroy@...nel.org,
 linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev,
 bpf@...r.kernel.org, youling.tang@...ux.dev, jianghaoran@...inos.cn,
 vincent.mc.li@...il.com, linux-trace-kernel@...r.kernel.org, Youling Tang
 <tangyouling@...inos.cn>
Subject: Re: [PATCH v3 4/4] LoongArch: ftrace: Adjust register stack restore
 order in direct call trampolines

On Tue, 16 Dec 2025 17:47:53 +0800
Chenghao Duan <duanchenghao@...inos.cn> wrote:

> Ensure that in the ftrace direct call logic, the CPU register state
> (with ra = parent return address) is restored to the correct state
> after the execution of the custom trampoline function and before
> returning to the traced function. Additionally, guarantee the
> correctness of the jump logic for jr t0 (traced function address).
> 
> Reported-by: Youling Tang <tangyouling@...inos.cn>
> Signed-off-by: Chenghao Duan <duanchenghao@...inos.cn>
> ---
>  samples/ftrace/ftrace-direct-modify.c       | 8 ++++----
>  samples/ftrace/ftrace-direct-multi-modify.c | 8 ++++----
>  samples/ftrace/ftrace-direct-multi.c        | 4 ++--
>  samples/ftrace/ftrace-direct-too.c          | 4 ++--
>  samples/ftrace/ftrace-direct.c              | 4 ++--
>  5 files changed, 14 insertions(+), 14 deletions(-)

This is all LoongArch specific, but in case you need this to go through
your tree:

Acked-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve