linux-kernel - Re: [PATCH v3 1/3] riscv: remove irqflags.h inclusion in asm/bitops.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aUGZTkLGYuew7-s1@yury>
Date: Tue, 16 Dec 2025 12:39:26 -0500
From: Yury Norov <yury.norov@...il.com>
To: Yunhui Cui <cuiyunhui@...edance.com>
Cc: aou@...s.berkeley.edu, alex@...ti.fr, andii@...nel.org,
	andybnac@...il.com, apatel@...tanamicro.com, ast@...nel.org,
	ben.dooks@...ethink.co.uk, bjorn@...nel.org, bpf@...r.kernel.org,
	charlie@...osinc.com, cl@...two.org, conor.dooley@...rochip.com,
	cyrilbur@...storrent.com, daniel@...earbox.net, debug@...osinc.com,
	dennis@...nel.org, eddyz87@...il.com, haoluo@...gle.com,
	john.fastabend@...il.com, jolsa@...nel.org, kpsingh@...nel.org,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	linux-riscv@...ts.infradead.org, linux@...musvillemoes.dk,
	martin.lau@...ux.dev, palmer@...belt.com, pjw@...nel.org,
	puranjay@...nel.org, pulehui@...wei.com, ruanjinjie@...wei.com,
	rkrcmar@...tanamicro.com, samuel.holland@...ive.com,
	sdf@...ichev.me, song@...nel.org, tglx@...utronix.de, tj@...nel.org,
	thuth@...hat.com, yonghong.song@...ux.dev, zong.li@...ive.com
Subject: Re: [PATCH v3 1/3] riscv: remove irqflags.h inclusion in asm/bitops.h

On Tue, Dec 16, 2025 at 09:47:19AM +0800, Yunhui Cui wrote:
> The arch/riscv/include/asm/bitops.h does not functionally require
> including /linux/irqflags.h. Additionally, adding
> arch/riscv/include/asm/percpu.h causes a circular inclusion:
> kernel/bounds.c
> ->include/linux/log2.h
> ->include/linux/bitops.h
> ->arch/riscv/include/asm/bitops.h
> ->include/linux/irqflags.h
> ->include/linux/find.h
> ->return val ? __ffs(val) : size;
> ->arch/riscv/include/asm/bitops.h
> 
> The compilation log is as follows:
> CC      kernel/bounds.s
> In file included from ./include/linux/bitmap.h:11,
>                from ./include/linux/cpumask.h:12,
>                from ./arch/riscv/include/asm/processor.h:55,
>                from ./arch/riscv/include/asm/thread_info.h:42,
>                from ./include/linux/thread_info.h:60,
>                from ./include/asm-generic/preempt.h:5,
>                from ./arch/riscv/include/generated/asm/preempt.h:1,
>                from ./include/linux/preempt.h:79,
>                from ./arch/riscv/include/asm/percpu.h:8,
>                from ./include/linux/irqflags.h:19,
>                from ./arch/riscv/include/asm/bitops.h:14,
>                from ./include/linux/bitops.h:68,
>                from ./include/linux/log2.h:12,
>                from kernel/bounds.c:13:
> ./include/linux/find.h: In function 'find_next_bit':
> ./include/linux/find.h:66:30: error: implicit declaration of function '__ffs' [-Wimplicit-function-declaration]
>    66 |                 return val ? __ffs(val) : size;
>       |                              ^~~~~
> 
> Signed-off-by: Yunhui Cui <cuiyunhui@...edance.com>

Acked-by: Yury Norov (NVIDIA) <yury.norov@...il.com>

> ---
>  arch/riscv/include/asm/bitops.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/riscv/include/asm/bitops.h b/arch/riscv/include/asm/bitops.h
> index 238092125c118..3c1a15be54d80 100644
> --- a/arch/riscv/include/asm/bitops.h
> +++ b/arch/riscv/include/asm/bitops.h
> @@ -11,7 +11,6 @@
>  #endif /* _LINUX_BITOPS_H */
>  
>  #include <linux/compiler.h>
> -#include <linux/irqflags.h>
>  #include <asm/barrier.h>
>  #include <asm/bitsperlong.h>
>  
> -- 
> 2.39.5